chore: always render ActionMenu in viewport when inside Dialog under feature flag by francinelucca · Pull Request #7524 · primer/react

francinelucca · 2026-02-11T02:01:42Z

Relates to https://github.com/github/primer/issues/6361

Implements @TylerDixon's suggestion to have the ActionMenu.Overlay be able to detect if its being rendered inside a Dialog (via a (new) DialogContext) to then apply displayInViewport=true. Adding this under a feature flag since its somewhat of a widespread change.

Changelog

New

add DialogContext to Dialog
Added the primer_react_action_menu_display_in_viewport_inside_dialog feature flag to DefaultFeatureFlags, enabling control over overlay display behavior inside dialogs.
Updated ActionMenu.Overlay to use the new feature flag and detect if it is inside a Dialog, modifying the displayInViewport prop logic accordingly.

Changed

Wrapped the ActionMenu InsideDialog story in FeatureFlags and removed the explicit displayInViewport prop from ActionMenu.Overlay, relying on the feature flag for behavior.

Removed

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

…feature flag

changeset-bot · 2026-02-11T02:01:47Z

🦋 Changeset detected

Latest commit: 72fd11f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-02-11T02:02:18Z

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copilot

Pull request overview

Adds a feature-flagged behavior change so ActionMenu.Overlay can automatically opt into displayInViewport when rendered inside a portal (e.g., inside a Dialog), aiming to improve overlay positioning/clipping in portaled contexts.

Changes:

Adds a new default feature flag: primer_react_action_menu_display_in_viewport_inside_portal.
Updates ActionMenu.Overlay to consult the feature flag and detect whether it is inside a portal to adjust displayInViewport.
Updates the InsideDialog ActionMenu story to enable the flag and remove the explicit displayInViewport prop.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
packages/react/src/Portal/Portal.tsx	Attempts to ensure a “default” `PortalContext` exists so descendants can detect portal rendering.
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts	Registers the new feature flag with a default value of `false`.
packages/react/src/ActionMenu/ActionMenu.tsx	Adds feature-flag logic and portal detection to influence `displayInViewport`.
packages/react/src/ActionMenu/ActionMenu.examples.stories.tsx	Enables the feature flag in the `InsideDialog` story and relies on the new default behavior.

packages/react/src/Portal/Portal.tsx

packages/react/src/ActionMenu/ActionMenu.tsx

Copilot · 2026-02-11T02:15:52Z

@francinelucca I've opened a new pull request, #7525, to work on those changes. Once the pull request is ready, I'll request review from you.

Updated the version of '@primer/react' from patch to minor and modified the ActionMenu rendering behavior.

…ithub.com:primer/react into chore/action-menu-display-in-viewport-enhancement

…e_portal feature flag (#7525) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

packages/react/src/Dialog/index.tsx

.changeset/stupid-bees-marry.md

packages/react/src/ActionMenu/ActionMenu.tsx

packages/react/src/ActionMenu/ActionMenu.examples.stories.tsx

siddharthkp

Left one clarifying question, everything else looks great! Approving in advance!

siddharthkp · 2026-02-16T12:08:44Z

packages/react/src/ActionMenu/ActionMenu.tsx

      variant={variant}
-      displayInViewport={displayInViewport}
+      displayInViewport={
+        displayInViewport !== undefined ? displayInViewport : featureFlagDisplayInViewportInsidePortal && isInsideDialog


Interesting that we have this in props and automatically applied from context. Should we remove it from props or do we want to preserve displayInViewport=false as an override?

I was wanting to let the gate open for someone to want to do displayInViewport=true ad-hoc. (like if your ActionMenu is not inside a Dialog, but you still want to force it to displayInViewPort. A good use-case I see for this would be the "close as" - completed, duplicate - not planned - menu for issues when inside the sidebar - it works well now due to some marie-fu, but this'd be a much cleaner solution - ).
And then I got to thinking that if we allow displayInViewport=true, then we should probably allow displayInViewport=false to override the default behavior, hence this seemingly weird conditional. Thoughts?

…ement

Copilot · 2026-02-18T04:43:16Z

@francinelucca I've opened a new pull request, #7565, to work on those changes. Once the pull request is ready, I'll request review from you.

…rtal (#7565) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

…ement

chore: always render ActionMenu in viewport when inside portal udner …

97585b9

…feature flag

francinelucca requested a review from a team as a code owner February 11, 2026 02:01

francinelucca requested review from Copilot and llastflowers February 11, 2026 02:01

francinelucca requested review from TylerJDev and siddharthkp February 11, 2026 02:01

github-actions bot added the staff Author is a staff member label Feb 11, 2026

Copilot started reviewing on behalf of francinelucca February 11, 2026 02:02 View session

github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 11, 2026

allow displayInViewport to override default behavior

eda30aa

Copilot AI reviewed Feb 11, 2026

View reviewed changes

packages/react/src/Portal/Portal.tsx Outdated Show resolved Hide resolved

packages/react/src/ActionMenu/ActionMenu.tsx Outdated Show resolved Hide resolved

packages/react/src/ActionMenu/ActionMenu.tsx Outdated Show resolved Hide resolved

github-actions bot requested a deployment to storybook-preview-7524 February 11, 2026 02:08 Abandoned

francinelucca marked this pull request as draft February 11, 2026 02:11

francinelucca added 2 commits February 10, 2026 21:13

PortalContext fix

c4f0c1a

lint fix

b661602

Copilot AI mentioned this pull request Feb 11, 2026

Add unit tests for primer_react_action_menu_display_in_viewport_inside_portal feature flag #7525

Merged

13 tasks

Change '@primer/react' version and update ActionMenu

a54a445

Updated the version of '@primer/react' from patch to minor and modified the ActionMenu rendering behavior.

github-actions bot temporarily deployed to storybook-preview-7524 February 11, 2026 02:17 Inactive

francinelucca deployed to github-pages February 11, 2026 02:27 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-7524 February 11, 2026 02:27 Inactive

francinelucca added 2 commits February 10, 2026 21:57

ensureDefaultPortal if the containerName is the default

97c46df

Merge branch 'chore/action-menu-display-in-viewport-enhancement' of g…

3c57fcc

…ithub.com:primer/react into chore/action-menu-display-in-viewport-enhancement

francinelucca deployed to github-pages February 11, 2026 03:06 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-7524 February 11, 2026 03:07 Inactive

Add unit tests for primer_react_action_menu_display_in_viewport_insid…

06ed903

…e_portal feature flag (#7525) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

francinelucca requested a review from Copilot February 11, 2026 03:30

Copilot started reviewing on behalf of francinelucca February 11, 2026 03:31 View session

github-actions bot temporarily deployed to storybook-preview-7524 February 13, 2026 04:58 Inactive

francinelucca added 2 commits February 13, 2026 00:07

fix ActionMenu tests

eea8174

fix Dialog exports

b43f157

francinelucca changed the title ~~chore: always render ActionMenu in viewport when inside portal under feature flag~~ chore: always render ActionMenu in viewport when inside Dialog under feature flag Feb 13, 2026

francinelucca requested review from Copilot and siddharthkp February 13, 2026 05:13

Copilot started reviewing on behalf of francinelucca February 13, 2026 05:13 View session

github-actions bot requested a deployment to storybook-preview-7524 February 13, 2026 05:14 Abandoned

francinelucca and others added 2 commits February 13, 2026 00:15

lint

c0510d4

Update ActionMenu rendering context in changeset

1680a45

Copilot AI reviewed Feb 13, 2026

View reviewed changes

packages/react/src/Dialog/index.tsx Show resolved Hide resolved

.changeset/stupid-bees-marry.md Show resolved Hide resolved

packages/react/src/ActionMenu/ActionMenu.tsx Show resolved Hide resolved

packages/react/src/ActionMenu/ActionMenu.tsx Outdated Show resolved Hide resolved

github-actions bot requested a deployment to storybook-preview-7524 February 13, 2026 05:19 Abandoned

francinelucca deployed to github-pages February 13, 2026 05:28 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-7524 February 13, 2026 05:28 Inactive

siddharthkp reviewed Feb 16, 2026

View reviewed changes

packages/react/src/ActionMenu/ActionMenu.examples.stories.tsx Show resolved Hide resolved

siddharthkp approved these changes Feb 16, 2026

View reviewed changes

Merge branch 'main' into chore/action-menu-display-in-viewport-enhanc…

b1e0e2a

…ement

Copilot AI mentioned this pull request Feb 18, 2026

Rename variable to match feature flag name: InsideDialog not InsidePortal #7565

Merged

10 tasks

francinelucca deployed to github-pages February 18, 2026 04:51 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-7524 February 18, 2026 04:52 Inactive

Rename variable to match feature flag name: InsideDialog not InsidePo…

ce6f502

…rtal (#7565) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

francinelucca requested a review from siddharthkp February 18, 2026 04:53

francinelucca deployed to github-pages February 18, 2026 05:03 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-7524 February 18, 2026 05:03 Inactive

siddharthkp approved these changes Feb 18, 2026

View reviewed changes

Merge branch 'main' into chore/action-menu-display-in-viewport-enhanc…

72fd11f

…ement

francinelucca deployed to github-pages February 18, 2026 15:50 — with GitHub Actions View deployment

github-actions bot deployed to storybook-preview-7524 February 18, 2026 15:51 View deployment

TylerJDev approved these changes Feb 20, 2026

View reviewed changes

Comments

Conversation

francinelucca commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-bot bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siddharthkp left a comment

Choose a reason for hiding this comment

Uh oh!

siddharthkp Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

francinelucca Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

francinelucca commented Feb 11, 2026 •

edited

Loading

changeset-bot bot commented Feb 11, 2026 •

edited

Loading