FIPS202/x86_64: Don't use native x4 backend on x86_64 when not needed#1032
Merged
mkannwischer merged 1 commit intomainfrom Apr 12, 2026
Merged
FIPS202/x86_64: Don't use native x4 backend on x86_64 when not needed#1032mkannwischer merged 1 commit intomainfrom
mkannwischer merged 1 commit intomainfrom
Conversation
Contributor
CBMC Results (ML-DSA-87)
Full Results (186 proofs)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (186 proofs)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (186 proofs)
|
Contributor
|
Thanks @flynd. Can you elaborate how this matches the AArch64 behavior? I don't see a matching guard in the AArch64 backend. |
Contributor
Author
This was a commit you made (added to my stack in PR #1000) that I noticed didn't have any dependencies to that stack. I see now that you're referring to one of my commits so the commit message is now referring to something that doesn't exist on master yet. I will grab the relevant parts of my commit and add to this PR to make it consistent. |
0b8f3f2 to
c29f36d
Compare
mkannwischer
approved these changes
Apr 12, 2026
Contributor
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @flynd! LGTM.
When building with MLD_CONFIG_SERIAL_FIPS202_ONLY, Keccak-f1600x2/x4 is not used and can be skipped. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
c29f36d to
f773262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the AArch64 behavior and skip the native Keccak-f1600x4 backend when MLD_CONFIG_SERIAL_FIPS202_ONLY or MLD_CONFIG_REDUCE_RAM is set.
This change was part of PR #1000 but doesn't need to be part of that stack.