Skip to content

Add configs to disable unused APIs [full CI]#1000

Open
mkannwischer wants to merge 11 commits intomainfrom
config-disable-apis
Open

Add configs to disable unused APIs [full CI]#1000
mkannwischer wants to merge 11 commits intomainfrom
config-disable-apis

Conversation

@mkannwischer
Copy link
Copy Markdown
Contributor

Continuation of #960 by @flynd to run full CI.

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Mar 21, 2026

CBMC Results (ML-DSA-65)

⚠️ Attention Required

Proof Status Current Previous Change
**TOTAL** ⚠️ 3843s 2477s +55.1%
mld_attempt_signature_generation ⚠️ 204s 114s +79%
polyvecl_pointwise_acc_montgomery_c ⚠️ 1613s 290s +456%
Full Results (186 proofs)
Proof Status Current Previous Change
**TOTAL** ⚠️ 3843s 2477s +55.1%
polyvecl_pointwise_acc_montgomery_c ⚠️ 1613s 290s +456%
sign_verify_internal 295s 308s -4%
mld_attempt_signature_generation ⚠️ 204s 114s +79%
poly_pointwise_montgomery_c 185s 256s -28%
rej_uniform_native 158s 147s +7%
mld_invntt_layer 92s 96s -4%
polyvec_matrix_expand_serial 89s 83s +7%
mld_ct_memcmp 88s 76s +16%
polyvec_matrix_expand 87s 107s -19%
mld_ntt_layer 61s 55s +11%
mld_compute_t0_t1_tr_from_sk_components 26s 27s -4%
sign_signature_internal 25s 23s +9%
poly_chknorm_c 23s 20s +15%
rej_uniform 23s 22s +5%
fqmul 22s 21s +5%
polyveck_decompose 18s 17s +6%
poly_add 16s 12s +33%
poly_uniform_eta_4x 16s 16s +0%
rej_uniform_c 16s 13s +23%
keccakf1600x4_permute_native 15s 14s +7%
mld_ntt_butterfly_block 15s 15s +0%
poly_uniform_4x 15s 18s -17%
polymat_permute_bitrev_to_custom 15s 35s -57%
polyt0_unpack 14s 15s -7%
polyvec_matrix_pointwise_montgomery 13s 11s +18%
polyveck_power2round 12s 13s -8%
keccak_absorb_once_x4 11s 10s +10%
polyveck_shiftl 10s 7s +43%
keccak_squeezeblocks_x4 9s 10s -10%
mld_check_pct 9s 13s -31%
mld_polyvecl_permute_bitrev_to_custom_native 9s 9s +0%
polyveck_add 9s 8s +12%
polyveck_pointwise_poly_montgomery 9s 9s +0%
polyveck_use_hint 9s 24s -62%
polyvecl_ntt 9s 8s +12%
keccakf1600_permute 8s 8s +0%
keccakf1600_permute_native 8s 10s -20%
poly_invntt_tomont_c 8s 9s -11%
poly_power2round 8s 5s +60%
polyeta_unpack 8s 6s +33%
polyveck_caddq 8s 7s +14%
polyveck_ntt 8s 9s -11%
sign 8s 7s +14%
sign_pk_from_sk 8s 10s -20%
keccak_absorb 7s 6s +17%
mld_sample_s1_s2 7s 3s +133%
poly_caddq 7s 1s +600%
poly_caddq_c 7s 4s +75%
poly_decompose_c 7s 9s -22%
polyveck_chknorm 7s 9s -22%
polyveck_invntt_tomont 7s 8s -12%
sign_keypair 7s 5s +40%
unpack_sk 7s 7s +0%
caddq 6s 3s +100%
mld_compute_pack_z 6s 5s +20%
mld_sample_s1_s2_serial 6s 5s +20%
pointwise_acc_native_x86_64 6s 7s -14%
poly_challenge 6s 4s +50%
poly_uniform_gamma1 6s 2s +200%
polyeta_pack 6s 2s +200%
polyveck_reduce 6s 7s -14%
polyveck_sub 6s 9s -33%
sign_verify_extmu 6s 4s +50%
unpack_hints 6s 3s +100%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 5s 4s +25%
make_hint 5s 2s +150%
mld_h 5s 4s +25%
montgomery_reduce 5s 3s +67%
poly_chknorm 5s 3s +67%
poly_uniform_gamma1_4x 5s 6s -17%
polyvecl_chknorm 5s 4s +25%
polyvecl_pointwise_acc_montgomery_native 5s 4s +25%
rej_eta_c 5s 3s +67%
sign_keypair_internal 5s 6s -17%
sign_open 5s 6s -17%
fqscale 4s 3s +33%
keccak_init 4s 3s +33%
keccakf1600_xor_bytes (big endian) 4s 2s +100%
keccakf1600x4_permute 4s 4s +0%
mld_ct_cmask_nonzero_u32 4s 2s +100%
mld_ct_get_optblocker_i64 4s 4s +0%
mld_ct_get_optblocker_u32 4s 1s +300%
mld_value_barrier_u32 4s 4s +0%
ntt_native_x86_64 4s 4s +0%
pack_pk 4s 3s +33%
pack_sig_c 4s 3s +33%
pack_sig_z 4s 1s +300%
pack_sk 4s 3s +33%
pointwise_acc_native_aarch64 4s 4s +0%
pointwise_native_aarch64 4s 3s +33%
poly_caddq_native 4s 2s +100%
poly_ntt_c 4s 3s +33%
poly_uniform_eta 4s 4s +0%
poly_use_hint 4s 3s +33%
poly_use_hint_c 4s 5s -20%
polyt0_pack 4s 3s +33%
polyveck_pack_eta 4s 5s -20%
polyveck_pack_t0 4s 3s +33%
polyveck_unpack_t0 4s 2s +100%
polyvecl_permute_bitrev_to_custom 4s 4s +0%
polyvecl_pointwise_acc_montgomery 4s 3s +33%
polyvecl_uniform_gamma1 4s 3s +33%
polyw1_pack 4s 4s +0%
polyz_pack 4s 4s +0%
polyz_unpack 4s 4s +0%
polyz_unpack_native 4s 4s +0%
rej_eta_native 4s 2s +100%
shake128_release 4s 2s +100%
shake128x4_absorb_once 4s 1s +300%
shake256 4s 1s +300%
sign_signature 4s 4s +0%
sign_signature_extmu 4s 4s +0%
sign_signature_pre_hash_internal 4s 4s +0%
sign_signature_pre_hash_shake256 4s 6s -33%
sign_verify 4s 2s +100%
sign_verify_pre_hash_shake256 4s 4s +0%
sys_check_capability 4s 4s +0%
unpack_pk 4s 3s +33%
intt_native_x86_64 3s 2s +50%
keccak_finalize 3s 3s +0%
keccak_squeeze 3s 3s +0%
keccakf1600_extract_bytes (big endian) 3s 2s +50%
keccakf1600_xor_bytes 3s 3s +0%
keccakf1600x4_xor_bytes 3s 2s +50%
mld_ct_abs_i32 3s 3s +0%
mld_ct_cmask_nonzero_u8 3s 3s +0%
mld_ct_sel_int32 3s 2s +50%
mld_prepare_domain_separation_prefix 3s 5s -40%
mld_value_barrier_i64 3s 2s +50%
ntt_native_aarch64 3s 5s -40%
poly_caddq_native_aarch64 3s 2s +50%
poly_chknorm_native 3s 4s -25%
poly_chknorm_native_aarch64 3s 3s +0%
poly_decompose 3s 3s +0%
poly_decompose_native 3s 4s -25%
poly_make_hint 3s 3s +0%
poly_ntt 3s 3s +0%
poly_ntt_native 3s 5s -40%
poly_pointwise_montgomery 3s 3s +0%
poly_pointwise_montgomery_native 3s 3s +0%
poly_reduce 3s 2s +50%
poly_sub 3s 3s +0%
poly_uniform 3s 7s -57%
poly_use_hint_native 3s 5s -40%
polyt1_pack 3s 3s +0%
polyt1_unpack 3s 3s +0%
polyveck_pack_w1 3s 5s -40%
polyveck_unpack_eta 3s 1s +200%
polyvecl_pack_eta 3s 4s -25%
polyvecl_uniform_gamma1_serial 3s 4s -25%
polyvecl_unpack_eta 3s 3s +0%
polyz_unpack_c 3s 3s +0%
power2round 3s 4s -25%
reduce32 3s 3s +0%
shake128x4_squeezeblocks 3s 4s -25%
shake256_init 3s 2s +50%
shake256_squeeze 3s 1s +200%
shake256x4_squeezeblocks 3s 2s +50%
sign_verify_pre_hash_internal 3s 6s -50%
unpack_sig 3s 5s -40%
use_hint 3s 3s +0%
decompose 2s 5s -60%
keccak_f1600_x1_native_aarch64 2s 3s -33%
keccak_f1600_x4_native_aarch64_v84a 2s 1s +100%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 1s +100%
keccakf1600x4_extract_bytes 2s 2s +0%
mld_ct_get_optblocker_u8 2s 3s -33%
mld_value_barrier_u8 2s 2s +0%
pack_sig_h_poly 2s 2s +0%
pointwise_native_x86_64 2s 3s -33%
poly_invntt_tomont 2s 1s +100%
poly_invntt_tomont_native 2s 3s -33%
poly_shiftl 2s 3s -33%
polyvecl_unpack_z 2s 5s -60%
rej_eta 2s 2s +0%
shake128_absorb 2s 3s -33%
shake128_finalize 2s 3s -33%
shake128_init 2s 1s +100%
shake256_absorb 2s 2s +0%
shake256_finalize 2s 2s +0%
shake256_release 2s 3s -33%
shake256x4_absorb_once 2s 2s +0%
keccak_f1600_x1_native_aarch64_v84a 1s 1s +0%
mld_ct_cmask_neg_i32 1s 2s -50%
mld_keccakf1600_extract_bytes 1s 2s -50%
shake128_squeeze 1s 1s +0%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Mar 21, 2026

CBMC Results (ML-DSA-44)

Full Results (186 proofs)
Proof Status Current Previous Change
**TOTAL** 1936s 2347s -17.5%
poly_pointwise_montgomery_c 184s 164s +12%
polyvecl_pointwise_acc_montgomery_c 165s 381s -57%
rej_uniform_native 163s 153s +7%
sign_verify_internal 127s 168s -24%
mld_attempt_signature_generation 117s 291s -60%
mld_invntt_layer 95s 120s -21%
mld_ct_memcmp 84s 80s +5%
mld_ntt_layer 60s 56s +7%
poly_invntt_tomont_c 30s 26s +15%
poly_chknorm_c 23s 20s +15%
sign_signature_internal 22s 21s +5%
fqmul 21s 17s +24%
rej_uniform 21s 22s -5%
polyvec_matrix_expand 19s 23s -17%
polyeta_unpack 18s 19s -5%
poly_uniform_eta_4x 16s 16s +0%
polyt0_unpack 16s 16s +0%
rej_uniform_c 16s 16s +0%
poly_add 15s 11s +36%
poly_uniform_4x 15s 13s +15%
mld_ntt_butterfly_block 14s 13s +8%
polyveck_add 14s 5s +180%
mld_check_pct 13s 13s +0%
mld_compute_t0_t1_tr_from_sk_components 13s 13s +0%
polyz_unpack_c 13s 11s +18%
keccakf1600x4_permute_native 12s 13s -8%
polymat_permute_bitrev_to_custom 11s 32s -66%
polyvec_matrix_pointwise_montgomery 10s 9s +11%
sign 10s 6s +67%
keccak_absorb_once_x4 9s 8s +12%
mld_polyvecl_permute_bitrev_to_custom_native 9s 11s -18%
sign_pk_from_sk 9s 6s +50%
unpack_sk 9s 6s +50%
keccak_absorb 8s 8s +0%
keccakf1600_permute_native 8s 6s +33%
pointwise_acc_native_x86_64 8s 5s +60%
polyveck_decompose 8s 5s +60%
keccak_squeezeblocks_x4 7s 7s +0%
keccakf1600_permute 7s 7s +0%
mld_compute_pack_z 7s 7s +0%
poly_challenge 7s 5s +40%
poly_power2round 7s 8s -12%
polyvec_matrix_expand_serial 7s 22s -68%
polyveck_sub 7s 4s +75%
sign_signature_pre_hash_internal 7s 5s +40%
sign_verify 7s 5s +40%
caddq 6s 3s +100%
poly_use_hint_native 6s 4s +50%
polyt0_pack 6s 6s +0%
polyvecl_chknorm 6s 4s +50%
polyvecl_ntt 6s 5s +20%
sign_signature_extmu 6s 2s +200%
sign_verify_extmu 6s 3s +100%
decompose 5s 3s +67%
keccakf1600x4_extract_bytes 5s 2s +150%
mld_sample_s1_s2_serial 5s 3s +67%
montgomery_reduce 5s 4s +25%
pack_sig_c 5s 2s +150%
pack_sig_h_poly 5s 2s +150%
pack_sk 5s 3s +67%
pointwise_acc_native_aarch64 5s 6s -17%
pointwise_native_aarch64 5s 3s +67%
poly_caddq_c 5s 6s -17%
poly_ntt_c 5s 3s +67%
poly_use_hint_c 5s 5s +0%
polyt1_unpack 5s 5s +0%
polyveck_ntt 5s 5s +0%
polyveck_pack_t0 5s 2s +150%
polyveck_pack_w1 5s 3s +67%
polyveck_power2round 5s 6s -17%
polyveck_unpack_t0 5s 1s +400%
polyveck_use_hint 5s 6s -17%
polyvecl_permute_bitrev_to_custom 5s 3s +67%
polyvecl_pointwise_acc_montgomery_native 5s 2s +150%
polyvecl_unpack_eta 5s 2s +150%
reduce32 5s 3s +67%
rej_eta_c 5s 4s +25%
rej_eta_native 5s 6s -17%
sign_signature_pre_hash_shake256 5s 3s +67%
sign_verify_pre_hash_shake256 5s 2s +150%
intt_native_x86_64 4s 5s -20%
keccak_finalize 4s 4s +0%
keccakf1600_extract_bytes (big endian) 4s 3s +33%
mld_ct_get_optblocker_u8 4s 2s +100%
mld_h 4s 4s +0%
mld_prepare_domain_separation_prefix 4s 5s -20%
mld_sample_s1_s2 4s 3s +33%
poly_decompose_c 4s 2s +100%
poly_decompose_native 4s 2s +100%
poly_invntt_tomont 4s 2s +100%
poly_pointwise_montgomery 4s 5s -20%
poly_reduce 4s 3s +33%
poly_shiftl 4s 2s +100%
poly_uniform_eta 4s 4s +0%
polyveck_caddq 4s 6s -33%
polyveck_chknorm 4s 4s +0%
polyveck_pack_eta 4s 3s +33%
polyveck_pointwise_poly_montgomery 4s 2s +100%
polyveck_reduce 4s 4s +0%
polyvecl_unpack_z 4s 4s +0%
polyz_unpack_native 4s 3s +33%
shake256x4_absorb_once 4s 2s +100%
sign_keypair_internal 4s 6s -33%
sign_open 4s 6s -33%
unpack_hints 4s 5s -20%
fqscale 3s 3s +0%
keccak_f1600_x1_native_aarch64_v84a 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 3s 3s +0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 3s 6s -50%
keccak_init 3s 4s -25%
keccak_squeeze 3s 4s -25%
keccakf1600_xor_bytes 3s 1s +200%
keccakf1600x4_xor_bytes 3s 4s -25%
mld_value_barrier_u32 3s 2s +50%
ntt_native_aarch64 3s 3s +0%
pack_pk 3s 4s -25%
poly_caddq 3s 4s -25%
poly_caddq_native 3s 2s +50%
poly_chknorm 3s 6s -50%
poly_invntt_tomont_native 3s 3s +0%
poly_make_hint 3s 3s +0%
poly_uniform 3s 5s -40%
poly_uniform_gamma1_4x 3s 5s -40%
poly_use_hint 3s 3s +0%
polyt1_pack 3s 6s -50%
polyveck_invntt_tomont 3s 4s -25%
polyveck_shiftl 3s 4s -25%
polyveck_unpack_eta 3s 5s -40%
polyvecl_pack_eta 3s 3s +0%
polyvecl_uniform_gamma1 3s 5s -40%
polyvecl_uniform_gamma1_serial 3s 4s -25%
polyw1_pack 3s 4s -25%
power2round 3s 5s -40%
shake128x4_absorb_once 3s 4s -25%
shake128x4_squeezeblocks 3s 4s -25%
shake256_squeeze 3s 3s +0%
sign_keypair 3s 5s -40%
sign_signature 3s 6s -50%
sign_verify_pre_hash_internal 3s 3s +0%
unpack_pk 3s 2s +50%
keccak_f1600_x1_native_aarch64 2s 2s +0%
keccak_f1600_x4_native_aarch64_v84a 2s 2s +0%
keccakf1600_xor_bytes (big endian) 2s 2s +0%
keccakf1600x4_permute 2s 3s -33%
make_hint 2s 3s -33%
mld_ct_abs_i32 2s 3s -33%
mld_ct_cmask_neg_i32 2s 3s -33%
mld_ct_cmask_nonzero_u32 2s 2s +0%
mld_ct_cmask_nonzero_u8 2s 3s -33%
mld_ct_get_optblocker_i64 2s 2s +0%
mld_ct_get_optblocker_u32 2s 2s +0%
mld_keccakf1600_extract_bytes 2s 1s +100%
mld_value_barrier_i64 2s 2s +0%
mld_value_barrier_u8 2s 2s +0%
ntt_native_x86_64 2s 3s -33%
pack_sig_z 2s 5s -60%
pointwise_native_x86_64 2s 4s -50%
poly_chknorm_native 2s 3s -33%
poly_chknorm_native_aarch64 2s 2s +0%
poly_decompose 2s 3s -33%
poly_ntt 2s 3s -33%
poly_ntt_native 2s 2s +0%
poly_pointwise_montgomery_native 2s 2s +0%
poly_sub 2s 3s -33%
poly_uniform_gamma1 2s 2s +0%
polyvecl_pointwise_acc_montgomery 2s 4s -50%
polyz_pack 2s 3s -33%
polyz_unpack 2s 3s -33%
rej_eta 2s 4s -50%
shake128_absorb 2s 2s +0%
shake128_finalize 2s 2s +0%
shake128_squeeze 2s 5s -60%
shake256 2s 4s -50%
shake256_absorb 2s 1s +100%
shake256_finalize 2s 1s +100%
shake256_init 2s 3s -33%
shake256_release 2s 1s +100%
shake256x4_squeezeblocks 2s 2s +0%
sys_check_capability 2s 5s -60%
use_hint 2s 3s -33%
mld_ct_sel_int32 1s 3s -67%
poly_caddq_native_aarch64 1s 6s -83%
polyeta_pack 1s 3s -67%
shake128_init 1s 5s -80%
shake128_release 1s 1s +0%
unpack_sig 1s 2s -50%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Mar 21, 2026

CBMC Results (ML-DSA-87)

⚠️ Attention Required

Proof Status Current Previous Change
sign_verify_internal ⚠️ 206s 109s +89%
Full Results (186 proofs)
Proof Status Current Previous Change
**TOTAL** 2167s 2408s -10.0%
sign_verify_internal ⚠️ 206s 109s +89%
polyvecl_pointwise_acc_montgomery_c 191s 186s +3%
mld_attempt_signature_generation 160s 200s -20%
poly_pointwise_montgomery_c 143s 249s -43%
rej_uniform_native 141s 148s -5%
polyvec_matrix_expand 132s 237s -44%
mld_invntt_layer 83s 102s -19%
polyvec_matrix_expand_serial 81s 85s -5%
mld_ct_memcmp 74s 77s -4%
mld_ntt_layer 51s 57s -11%
sign_signature_internal 28s 41s -32%
polymat_permute_bitrev_to_custom 26s 28s -7%
mld_compute_t0_t1_tr_from_sk_components 22s 23s -4%
rej_uniform 20s 23s -13%
fqmul 19s 19s +0%
poly_uniform_eta_4x 16s 20s -20%
poly_uniform_4x 15s 17s -12%
polyeta_unpack 15s 18s -17%
polyveck_power2round 15s 15s +0%
mld_polyvecl_permute_bitrev_to_custom_native 14s 12s +17%
polyt0_unpack 14s 15s -7%
poly_chknorm_c 13s 19s -32%
mld_ntt_butterfly_block 12s 11s +9%
rej_uniform_c 12s 16s -25%
keccakf1600x4_permute_native 11s 13s -15%
mld_sample_s1_s2_serial 11s 7s +57%
poly_add 11s 10s +10%
polyveck_decompose 11s 11s +0%
polyveck_use_hint 11s 11s +0%
mld_check_pct 10s 12s -17%
polyveck_ntt 10s 8s +25%
unpack_sk 10s 10s +0%
keccak_absorb_once_x4 9s 11s -18%
polyveck_invntt_tomont 9s 11s -18%
sign 9s 7s +29%
sign_pk_from_sk 9s 8s +12%
pointwise_acc_native_aarch64 8s 7s +14%
poly_decompose_c 8s 5s +60%
poly_power2round 8s 4s +100%
polyvec_matrix_pointwise_montgomery 8s 10s -20%
polyveck_add 8s 8s +0%
polyveck_sub 8s 5s +60%
polyz_unpack_c 8s 9s -11%
keccakf1600_permute_native 7s 7s +0%
mld_compute_pack_z 7s 8s -12%
pointwise_acc_native_x86_64 7s 7s +0%
polyveck_pointwise_poly_montgomery 7s 8s -12%
polyveck_reduce 7s 7s +0%
polyvecl_chknorm 7s 5s +40%
polyvecl_ntt 7s 10s -30%
sign_open 7s 5s +40%
keccak_absorb 6s 7s -14%
keccakf1600_permute 6s 9s -33%
mld_ct_get_optblocker_u8 6s 2s +200%
mld_sample_s1_s2 6s 6s +0%
poly_challenge 6s 3s +100%
poly_invntt_tomont_c 6s 10s -40%
poly_ntt_c 6s 2s +200%
polyveck_caddq 6s 4s +50%
polyveck_shiftl 6s 8s -25%
sign_verify_pre_hash_shake256 6s 4s +50%
keccak_f1600_x1_native_aarch64 5s 2s +150%
poly_caddq_c 5s 5s +0%
poly_chknorm_native 5s 4s +25%
poly_invntt_tomont_native 5s 2s +150%
poly_uniform_gamma1_4x 5s 5s +0%
polyveck_chknorm 5s 7s -29%
polyvecl_unpack_z 5s 3s +67%
rej_eta_native 5s 5s +0%
sign_signature 5s 6s -17%
unpack_pk 5s 4s +25%
keccak_squeezeblocks_x4 4s 6s -33%
keccakf1600x4_permute 4s 4s +0%
mld_h 4s 3s +33%
ntt_native_x86_64 4s 3s +33%
pack_sig_h_poly 4s 3s +33%
pack_sig_z 4s 2s +100%
poly_decompose_native 4s 5s -20%
poly_make_hint 4s 2s +100%
poly_ntt 4s 2s +100%
poly_ntt_native 4s 2s +100%
poly_shiftl 4s 5s -20%
poly_uniform 4s 5s -20%
poly_uniform_eta 4s 4s +0%
poly_uniform_gamma1 4s 6s -33%
polyveck_unpack_t0 4s 4s +0%
polyvecl_permute_bitrev_to_custom 4s 3s +33%
polyvecl_uniform_gamma1 4s 5s -20%
polyw1_pack 4s 2s +100%
rej_eta 4s 2s +100%
rej_eta_c 4s 3s +33%
shake256 4s 3s +33%
shake256_absorb 4s 3s +33%
shake256_squeeze 4s 4s +0%
sign_keypair_internal 4s 8s -50%
sign_signature_pre_hash_internal 4s 5s -20%
sign_verify 4s 4s +0%
sign_verify_extmu 4s 2s +100%
sign_verify_pre_hash_internal 4s 3s +33%
unpack_hints 4s 5s -20%
caddq 3s 3s +0%
decompose 3s 4s -25%
fqscale 3s 5s -40%
intt_native_x86_64 3s 3s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 3s 1s +200%
keccak_finalize 3s 2s +50%
keccak_init 3s 2s +50%
keccakf1600_xor_bytes 3s 2s +50%
keccakf1600_xor_bytes (big endian) 3s 4s -25%
keccakf1600x4_extract_bytes 3s 3s +0%
make_hint 3s 4s -25%
mld_ct_cmask_nonzero_u8 3s 1s +200%
mld_prepare_domain_separation_prefix 3s 4s -25%
mld_value_barrier_u32 3s 3s +0%
mld_value_barrier_u8 3s 2s +50%
ntt_native_aarch64 3s 2s +50%
pack_sk 3s 3s +0%
pointwise_native_aarch64 3s 4s -25%
poly_caddq_native 3s 5s -40%
poly_caddq_native_aarch64 3s 4s -25%
poly_chknorm 3s 2s +50%
poly_pointwise_montgomery 3s 3s +0%
poly_reduce 3s 4s -25%
poly_sub 3s 3s +0%
polyeta_pack 3s 3s +0%
polyt0_pack 3s 5s -40%
polyt1_unpack 3s 3s +0%
polyveck_pack_w1 3s 4s -25%
polyveck_unpack_eta 3s 4s -25%
polyvecl_pack_eta 3s 1s +200%
polyvecl_pointwise_acc_montgomery 3s 5s -40%
polyvecl_uniform_gamma1_serial 3s 3s +0%
shake128_init 3s 1s +200%
shake128_release 3s 1s +200%
shake128_squeeze 3s 2s +50%
shake256x4_absorb_once 3s 2s +50%
shake256x4_squeezeblocks 3s 2s +50%
sign_keypair 3s 3s +0%
sign_signature_extmu 3s 5s -40%
sign_signature_pre_hash_shake256 3s 7s -57%
sys_check_capability 3s 2s +50%
unpack_sig 3s 3s +0%
keccak_f1600_x1_native_aarch64_v84a 2s 2s +0%
keccak_f1600_x4_native_aarch64_v84a 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 3s -33%
keccak_squeeze 2s 3s -33%
keccakf1600_extract_bytes (big endian) 2s 3s -33%
keccakf1600x4_xor_bytes 2s 4s -50%
mld_ct_abs_i32 2s 2s +0%
mld_ct_cmask_neg_i32 2s 4s -50%
mld_ct_get_optblocker_u32 2s 3s -33%
mld_keccakf1600_extract_bytes 2s 1s +100%
montgomery_reduce 2s 2s +0%
pack_pk 2s 2s +0%
pack_sig_c 2s 4s -50%
pointwise_native_x86_64 2s 4s -50%
poly_caddq 2s 3s -33%
poly_chknorm_native_aarch64 2s 2s +0%
poly_invntt_tomont 2s 1s +100%
poly_pointwise_montgomery_native 2s 2s +0%
poly_use_hint 2s 5s -60%
poly_use_hint_c 2s 2s +0%
poly_use_hint_native 2s 2s +0%
polyt1_pack 2s 2s +0%
polyveck_pack_eta 2s 4s -50%
polyveck_pack_t0 2s 3s -33%
polyvecl_pointwise_acc_montgomery_native 2s 5s -60%
polyvecl_unpack_eta 2s 3s -33%
power2round 2s 2s +0%
reduce32 2s 3s -33%
shake128_absorb 2s 1s +100%
shake128_finalize 2s 5s -60%
shake128x4_absorb_once 2s 3s -33%
shake128x4_squeezeblocks 2s 2s +0%
shake256_finalize 2s 2s +0%
shake256_init 2s 4s -50%
use_hint 2s 2s +0%
mld_ct_cmask_nonzero_u32 1s 2s -50%
mld_ct_get_optblocker_i64 1s 2s -50%
mld_ct_sel_int32 1s 2s -50%
mld_value_barrier_i64 1s 2s -50%
poly_decompose 1s 4s -75%
polyz_pack 1s 3s -67%
polyz_unpack 1s 3s -67%
polyz_unpack_native 1s 5s -80%
shake256_release 1s 2s -50%

@mkannwischer mkannwischer force-pushed the config-disable-apis branch 2 times, most recently from 0e7f1ba to 6b89fae Compare March 21, 2026 02:42
@mkannwischer mkannwischer marked this pull request as ready for review March 21, 2026 03:52
@mkannwischer mkannwischer requested a review from a team as a code owner March 21, 2026 03:52
@flynd flynd force-pushed the config-disable-apis branch 2 times, most recently from 54b3c74 to ec9c236 Compare March 23, 2026 13:17
@mkannwischer mkannwischer force-pushed the config-disable-apis branch 2 times, most recently from d868b27 to 70be886 Compare April 1, 2026 15:12
@flynd flynd force-pushed the config-disable-apis branch 4 times, most recently from 9ac9432 to dff98f0 Compare April 6, 2026 20:15
@flynd
Copy link
Copy Markdown
Contributor

flynd commented Apr 7, 2026

@hanno-becker : Any chance this can be approved soon? It's been almost 2 months since the first version of these changes and due to the size I need to do a lot of updates when rebasing onto other changes on main.
Also, we're very close to getting the final approval for the project where we will make use of mldsa-native so it would be good to have it on master so I can present a version that works without local patches.

@@ -0,0 +1,91 @@
/*
Copy link
Copy Markdown
Contributor

@hanno-becker hanno-becker Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... why is this a custom example rather than a custom config?

Right now, if I take out-of-the-box mldsa-native and just set MLD_CONFIG_NO_SIGN_API, a plain make fails.

Also, with the current approach we don't exercise a monobuild with reduced config, which would be useful to catch unused functions.

I would prefer custom configurations rather than a custom example here, and adjusting all existing tests and examples to only run those tests which make sense in the chosen configuration. This means make test works out of the box for any valid config, plus we extend coverage to monobuild and multilevel build.

This is currently a blocker to me.

Copy link
Copy Markdown
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the long silence, and thank you very much for all the work on this, @flynd @mkannwischer!

I support the change in principle, but the build + test story needs more work:

  • A plain make test should work with any valid config -- right now, it doesn't. The existing tests and examples need adjusting to only exercise the API that is enabled in the config.
  • Testing the reduced configurations through examples introduces test gaps; e.g., we don't exercise them in monobuilds.

ISTM that we should test this through config variations rather than new examples; this would force/solve both issues above.

@flynd
Copy link
Copy Markdown
Contributor

flynd commented Apr 8, 2026

I support the change in principle, but the build + test story needs more work:

  • A plain make test should work with any valid config -- right now, it doesn't. The existing tests and examples need adjusting to only exercise the API that is enabled in the config.
  • Testing the reduced configurations through examples introduces test gaps; e.g., we don't exercise them in monobuilds.

ISTM that we should test this through config variations rather than new examples; this would force/solve both issues above.

I had a look at the tests and this looks like a big change since the pattern of creating key, signing, and then verifying the signature will no longer work. As I'm not at all familiar with these tests, I don't know how to contribute such a change. Do either of you have the time to help out with this? If not, could you give some clear hints on how the tests should be modified and maybe I can try to figure it out.

I did notice though that there were two commits in the stack that could be merged separately so they are now moved to PRs #1029 and #1032.

@mkannwischer
Copy link
Copy Markdown
Contributor Author

mkannwischer commented Apr 9, 2026

I support the change in principle, but the build + test story needs more work:

  • A plain make test should work with any valid config -- right now, it doesn't. The existing tests and examples need adjusting to only exercise the API that is enabled in the config.
  • Testing the reduced configurations through examples introduces test gaps; e.g., we don't exercise them in monobuilds.

ISTM that we should test this through config variations rather than new examples; this would force/solve both issues above.

I had a look at the tests and this looks like a big change since the pattern of creating key, signing, and then verifying the signature will no longer work. As I'm not at all familiar with these tests, I don't know how to contribute such a change. Do either of you have the time to help out with this? If not, could you give some clear hints on how the tests should be modified and maybe I can try to figure it out.

I agree that this would be a major change. Every test and example would have to be changed to use known keys and signatures (and then compare the computed values against the known ones). ACVP would have to be entirely reworked because only parts of the tests would be executed. The KAT tests would be impossible.

@hanno-becker, would it be a compromise to get the monobuild tests to work with the new flags, but skip the tests that would require major rework for now and keep the examples instead? In a follow up we can address the skipped tests and eventually remove the examples if they are no longer needed. I think that would be more manageable, address the concern that make test and the monobuilds don't work with the new flags.

Unfortunately, I won't have time to help out beyond reviews in the next few weeks.

@mkannwischer
Copy link
Copy Markdown
Contributor Author

CBMC Results (ML-DSA-87)

⚠️ Attention Required

Proof Status Current Previous Change
polyvecl_pointwise_acc_montgomery_c ❌ - 218s -
polymat_permute_bitrev_to_custom ⚠️ 153s 27s +467%
Full Results (184 proofs)

This failure is likely unrelated to the changes. It's flaky also in other branches. Going to fix it.

@hanno-becker
Copy link
Copy Markdown
Contributor

I will take a look and get back to you.

@flynd flynd force-pushed the config-disable-apis branch from aff3b9f to 2cdf48a Compare April 10, 2026 11:09
@hanno-becker hanno-becker force-pushed the config-disable-apis branch 3 times, most recently from 8488c55 to 5cb62b8 Compare April 11, 2026 06:16
@hanno-becker
Copy link
Copy Markdown
Contributor

@flynd @mkannwischer I am having a stab at adjusting the tests. Needs a bit more care for CT but I hope to have it done by the end of the weekend.

@flynd flynd force-pushed the config-disable-apis branch from 5cb62b8 to 96228a7 Compare April 11, 2026 19:39
@hanno-becker hanno-becker force-pushed the config-disable-apis branch 3 times, most recently from 8bac7e8 to bb5eafc Compare April 12, 2026 05:04
@flynd flynd force-pushed the config-disable-apis branch from bb5eafc to 6109d2d Compare April 12, 2026 13:33
flynd and others added 10 commits April 13, 2026 06:00
Make it possible to exclude key generation when not needed, together
with all internal functions not needed for signature creation or
verification.

Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude signature creation when not needed, together
with all internal functions not needed for key generation or signature
verification.

Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude signature verification when not needed,
together with all internal functions not needed for key generation or
signature creation.

Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude code only used for signature creation or
verification.

Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude code only used for key generation or
verification.

Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude code only used for key generation or
signature creation.

Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude the wrapper APIs if not needed and build
only the internal API functions.

Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
… APIs

The PCT implementation internally calls crypto_sign_signature() and
crypto_sign_verify(), so it is incompatible with MLD_CONFIG_NO_SIGN_API
and MLD_CONFIG_NO_VERIFY_API.

Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Add examples testing four disabled API combinations (keygen-only,
sign-only, verify-only, sign+verify) across all three parameter sets.
disabled_apis_native additionally enables native arithmetic and FIPS-202
backends.

Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Previously, all config variations ran sequentially in a single job,
making it hard to identify which variation failed without inspecting
the full CI log. This commit splits them into grouped parallel jobs
(pct, reduce-ram, custom-hooks, native-cap, asm-fips202, nblocks,
reduced-api) so failures are visible from the job summary.

Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants