Skip to content

Conversation

@ljunkie
Copy link
Member

@ljunkie ljunkie commented Nov 27, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 27, 2025 04:18
@ljunkie ljunkie self-assigned this Nov 27, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a custom build and release infrastructure for Plex's fork of the BrightScript Language extension ("XELP"). It switches from upstream RokuCommunity dependencies to Plex-maintained forks and introduces a shadow release workflow for internal distribution.

Key Changes:

  • Replaces upstream brighterscript and brighterscript-formatter dependencies with Plex-maintained forks using git URLs and custom version tags
  • Adds a new xelp_shadow_release.yml workflow that creates versioned VSIX packages with date-based versioning
  • Disables existing RokuCommunity release workflows (by renaming to .disable extension) to prevent conflicts with the custom release process

Reviewed changes

Copilot reviewed 3 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
package.json Removes Node.js engine constraint; switches to forked brighterscript modules from plexinc GitHub
package-lock.json Updates lockfile to reflect git-based dependencies for brighterscript modules with specific commit hashes
.github/workflows/xelp_shadow_release.yml Adds new workflow for creating shadow releases with custom version numbering based on date stamps
.github/workflows/publish-release.yml.disable Disables original release publishing workflow to avoid conflicts with custom process
.github/workflows/make-release-artifacts.yml.disable Disables original release artifact creation workflow
.github/workflows/initialize-release.yml.disable Disables original release initialization workflow
.github/workflows/docs.yml.disable Disables documentation publishing workflow
.github/workflows/create-vsix.yml.disable Disables original VSIX creation workflow
.github/workflows/create-vsix-from-pr.yml.disable Disables PR-based VSIX creation workflow
.github/workflows/build.yml Removes Coveralls configuration and related environment variables from CI workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ljunkie ljunkie merged commit 1a8f8b0 into plexinc:xelp/main Nov 27, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant