Skip to content

Revert "[FIX] Fix ElementComponent 'mousemove' event firing outside element" #8413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willeastcott merged 1 commit into from
Jan 27, 2026
Merged

Revert "[FIX] Fix ElementComponent 'mousemove' event firing outside element" #8413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/framework/input/element-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,8 +733,8 @@ class ElementInput {
// currently hovered element is whatever's being pointed by mouse (which may be null)
this._hoveredElement = element;

// if there was a pressed element, it takes full priority of 'up' events for click detection
if (eventType === 'mouseup' && this._pressedElement) {
// if there was a pressed element, it takes full priority of 'move' and 'up' events
if ((eventType === 'mousemove' || eventType === 'mouseup') && this._pressedElement) {
this._fireEvent(eventType, new ElementMouseEvent(event, this._pressedElement, camera, targetX, targetY, this._lastX, this._lastY));
} else if (element) {
// otherwise, fire it to the currently hovered event
Expand Down
Loading