Revert "[FIX] Fix ElementComponent 'mousemove' event firing outside element" #8413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement (…" This reverts commit 33e0e63.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous fix (PR #8288) that had incorrectly changed how mousemove events are handled for pressed elements. The revert restores the original behavior where both mousemove and mouseup events are sent to the pressed element, aligning mouse event handling with the established touch event handling pattern.
Changes:
- Restores
mousemoveevents to be sent to the pressed element (in addition tomouseupevents) - Makes mouse event handling consistent with touch event handling behavior
- Fixes the condition check to include both
mousemoveandmouseupevent types when determining if events should be sent to the pressed element
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8288