implement finding msg for codeql #935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavedeluna
commented
Dec 2, 2024
| return result_set | ||
|
|
||
|
|
||
| # TODO: cache, make hashable |
Contributor
Author
There was a problem hiding this comment.
I don't have a ton of bandwidth so left it as a todo, since we're passing dict of lists and some other unhashable data here, it's not super fast to do, but we should do it at some point
clavedeluna
force-pushed
the
finding-msg
branch
from
081c0ea to
5145463
Compare
clavedeluna
force-pushed
the
finding-msg
branch
from
5145463 to
c16bb09
Compare
|
drdavella
reviewed
Dec 3, 2024
Member
drdavella
left a comment
drdavella
left a comment
There was a problem hiding this comment.
@clavedeluna I believe the need for this metadata exists not at the finding level but at the rule level. It's possible that we should expose this at the level of SarifResultSet as a mapping between rule IDs and metadata.
auto-merge was automatically disabled
December 4, 2024 20:42
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to gather as much finding metadata as possible. Implemented
finding_msgfor codeql, remaining tools as TODO