Skip to content

Commit c16bb09

Browse files
committed
fix syntax
1 parent d41881e commit c16bb09

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/codemodder/codeql.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def from_sarif(
4545
) -> Self:
4646
rule_id = cls.extract_rule_id(sarif_result, sarif_run, truncate_rule_id)
4747
text_for_rule = get_text_for_rule(rule_id, sarif_run)
48-
finding_msg = f"""{sarif_result['message']['text']}\n{text_for_rule}"""
48+
finding_msg = f"{sarif_result['message']['text']}\n{text_for_rule}"
4949
return cls(
5050
rule_id=rule_id,
5151
locations=cls.extract_locations(sarif_result),
@@ -87,5 +87,5 @@ def get_text_for_rule(rule_id: str, sarif_run: dict) -> str:
8787
for ext in sarif_run["tool"]["extensions"]:
8888
for rule in ext.get("rules", []):
8989
if rule["id"] == rule_id:
90-
return f"{rule["fullDescription"]["text"]}\n{rule["help"]["text"]}"
90+
return f"{rule.get('fullDescription', {}).get('text', '')}\n{rule.get('help', {}).get('text', '')}"
9191
return ""

tests/test_codeql.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,18 @@ def test_from_sarif(self):
209209
"driver": {"name": "CodeQL"},
210210
"extensions": [
211211
{
212+
"name": "codeql/python-queries",
212213
"rules": [
213-
{"id": "python/sql-injection"},
214+
{
215+
"id": "python/sql-injection",
216+
"fullDescription": {
217+
"text": "Some lengthy description."
218+
},
219+
"help": {"text": "Description\n"},
220+
},
214221
{"id": "cs/web/missing-x-frame-options"},
215222
{"id": "cs/web/xss"},
216-
]
223+
],
217224
},
218225
],
219226
},

0 commit comments

Comments
 (0)