Skip to content

chore(skills): unify PR stop condition to 3 passes #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreBrisorgueil merged 1 commit into from
Mar 20, 2026
Merged

chore(skills): unify PR stop condition to 3 passes #3285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/pull-request/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ REPEAT:
6. If actionable comments → fix all, /verify, commit, push, reply, resolve, consecutive_zero=0, GOTO 1
7. If non-actionable unresolved → reply all explaining why, resolve all, consecutive_zero=0, GOTO 5
8. If zero unresolved threads → consecutive_zero++
if consecutive_zero >= 2 → check branch protection (see 6f), then STOP ✓
if consecutive_zero >= 3 → check branch protection (see 6f), then STOP ✓
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stop condition is updated here to require 3 consecutive clean passes, but later in the same document (section 6f “Stop condition”) it still states “2 consecutive passes”. Please update that section to match the new 3-pass convergence rule so the instructions are consistent.

Suggested change
if consecutive_zero >= 3 → check branch protection (see 6f), then STOP ✓
if consecutive_zero >= 2 → check branch protection (see 6f), then STOP ✓

Copilot uses AI. Check for mistakes.
else GOTO 3
```

Expand Down
Loading