Skip to content

chore(skills): unify PR stop condition to 3 passes#3285

Merged
PierreBrisorgueil merged 1 commit intomasterfrom
chore/unify-pr-stop-condition
Mar 20, 2026
Merged

chore(skills): unify PR stop condition to 3 passes#3285
PierreBrisorgueil merged 1 commit intomasterfrom
chore/unify-pr-stop-condition

Conversation

@PierreBrisorgueil
Copy link
Contributor

@PierreBrisorgueil PierreBrisorgueil commented Mar 20, 2026

Aligns Node with Vue — both now require 3 consecutive clean passes with grace periods before declaring convergence.

Summary by CodeRabbit

  • Documentation
    • Updated internal documentation of monitoring processes and thresholds.

Copilot AI review requested due to automatic review settings March 20, 2026 17:37
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 44aefe8a-7ee7-4d78-a1a5-1fbb63fe8917

📥 Commits

Reviewing files that changed from the base of the PR and between 8b69820 and c74fc9e.

📒 Files selected for processing (1)
  • .claude/skills/pull-request/SKILL.md

Walkthrough

Documentation update to the pull-request skill that adjusts the monitor loop stop-condition threshold from 2 to 3 consecutive iterations with zero unresolved review threads before checking branch protection status.

Changes

Cohort / File(s) Summary
Monitor Loop Documentation
.claude/skills/pull-request/SKILL.md
Updated stop-condition threshold for consecutive zero-unresolved-thread iterations from 2 to 3 in the monitor loop control flow documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Chore

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/unify-pr-stop-condition

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PierreBrisorgueil PierreBrisorgueil merged commit 6faa331 into master Mar 20, 2026
4 of 5 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pull-request skill’s convergence logic to match the Vue workflow by requiring 3 consecutive clean passes (with grace periods) before stopping.

Changes:

  • Increase the monitor loop stop threshold from 2 to 3 consecutive “zero unresolved threads” passes.

7. If non-actionable unresolved → reply all explaining why, resolve all, consecutive_zero=0, GOTO 5
8. If zero unresolved threads → consecutive_zero++
if consecutive_zero >= 2 → check branch protection (see 6f), then STOP ✓
if consecutive_zero >= 3 → check branch protection (see 6f), then STOP ✓
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stop condition is updated here to require 3 consecutive clean passes, but later in the same document (section 6f “Stop condition”) it still states “2 consecutive passes”. Please update that section to match the new 3-pass convergence rule so the instructions are consistent.

Suggested change
if consecutive_zero >= 3 → check branch protection (see 6f), then STOP ✓
if consecutive_zero >= 2 → check branch protection (see 6f), then STOP ✓

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants