chore(skills): unify PR stop condition to 3 passes#3285
chore(skills): unify PR stop condition to 3 passes#3285PierreBrisorgueil merged 1 commit intomasterfrom
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughDocumentation update to the pull-request skill that adjusts the monitor loop stop-condition threshold from 2 to 3 consecutive iterations with zero unresolved review threads before checking branch protection status. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the pull-request skill’s convergence logic to match the Vue workflow by requiring 3 consecutive clean passes (with grace periods) before stopping.
Changes:
- Increase the monitor loop stop threshold from 2 to 3 consecutive “zero unresolved threads” passes.
| 7. If non-actionable unresolved → reply all explaining why, resolve all, consecutive_zero=0, GOTO 5 | ||
| 8. If zero unresolved threads → consecutive_zero++ | ||
| if consecutive_zero >= 2 → check branch protection (see 6f), then STOP ✓ | ||
| if consecutive_zero >= 3 → check branch protection (see 6f), then STOP ✓ |
There was a problem hiding this comment.
The stop condition is updated here to require 3 consecutive clean passes, but later in the same document (section 6f “Stop condition”) it still states “2 consecutive passes”. Please update that section to match the new 3-pass convergence rule so the instructions are consistent.
| if consecutive_zero >= 3 → check branch protection (see 6f), then STOP ✓ | |
| if consecutive_zero >= 2 → check branch protection (see 6f), then STOP ✓ |
Aligns Node with Vue — both now require 3 consecutive clean passes with grace periods before declaring convergence.
Summary by CodeRabbit