Zend: Fix anonymous closure names#19011
Merged
Girgias merged 2 commits intophp:masterfrom Jul 3, 2025
Merged
Conversation
Member
|
Related: #18063. |
arnaud-lb
approved these changes
Jul 3, 2025
Member
arnaud-lb
left a comment
arnaud-lb
left a comment
There was a problem hiding this comment.
This looks good to me in general.
Regarding PFAs: With the patch applied, zend_get_callable_name_ex() returns the underlying function name (without scope). I will adjust this in the PFA branch.
Co-authored-by: Arnaud Le Blanc <365207+arnaud-lb@users.noreply.github.com>
Member
|
Sorry I wasn't able to review this in time, I'll update #18932 with the results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this when looking at the test output of #18932 where the anonymous functions had a name of
Closure::_invokeinstead of the better names that @TimWolla introduced.@DanielEScherzer can you pull this patch for the PR to see what the test messages are?