Deprecate returning non-string values from a user output handler#18932
Deprecate returning non-string values from a user output handler#18932DanielEScherzer merged 15 commits intophp:masterfrom
Conversation
And update tests
8144c55 to
198a391
Compare
Girgias
left a comment
There was a problem hiding this comment.
Few nits, but looks mostly good :)
|
There was reason why we didn't merge this: See https://externals.io/message/124506#124666 . @DanielEScherzer have you considered all those edge cases? |
|
I think this should get another RFC that will in more detail consider output handler behavior. |
|
Or lets leave it as you put already some effort into this and we will see how it goes. It was strange edge case anyway and might be a bit unusual for people to do that. |
|
Hi folks, Thanks for working on this. I'm just trying to confirm whether
However in the testing I have tried to do, I am unable to trigger any deprecation notice. It would be good to confirm, and document, that this method is safe to usen with |
|
@DanielEScherzer Can you confirm re |
https://wiki.php.net/rfc/deprecations_php_8_4