Skip to content

Conversation

@jaredhendrickson13
Copy link
Member

New

Fixes

  • Fixes an issue where some services' status was not accurately obtained (/api/v2/status/services shows ipsec as not running but /api/v1/services does #634)
  • Fixes an issue where the WireGuard service's enabled status was not always represented correctly
  • Fixes an issue where the /api/v2/services/dhcp_server endpoints could not be used if any DHCP Relay configuration is currently in the config
  • Fixes an issue where /api/v2/services/dhcp_server did not accurately determine if a DHCP Relay was running

Changes

jaredhendrickson13 and others added 30 commits January 4, 2025 13:55
HAProxy: Set SSL offload certificates and alternate certificates via API
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces new API endpoints and fixes several service-related bugs while updating documentation to reflect these changes. Key changes include:

  • The addition of new endpoints for DHCP Relay and HAProxy services.
  • Several fixes for service status issues and DHCP server configurations.
  • Updates to documentation, including navigation updates in mkdocs.yml and expanded setup instructions.

Reviewed Changes

Copilot reviewed 8 out of 23 changed files in this pull request and generated 2 comments.

File Description
mkdocs.yml Added a navigation entry for the Security Policy documentation
docs/index.md Updated the "Important" block to link to the SECURITY.md file
docs/SECURITY.md Expanded and reformatted security policy details
docs/INSTALL_AND_CONFIG.md Revised update instructions and added guidance for backup and versioning
Files not reviewed (15)
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Core/Endpoint.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Core/Model.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Endpoints/ServicesDHCPRelayEndpoint.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Endpoints/ServicesHAProxyFrontendCertificateEndpoint.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/BINDZone.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/DHCPRelay.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/DHCPServer.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/HAProxyBackend.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/HAProxyFrontend.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/HAProxyFrontendCertificate.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/Service.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsBINDZoneTestCase.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsDHCPRelayTestCase.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsDHCPServerTestCase.inc: Language not supported
  • pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsHAProxyBackendTestCase.inc: Language not supported
Comments suppressed due to low confidence (2)

docs/index.md:43

  • The updated 'Important' block appears to break the sentence across lines, which might lead to unintended whitespace or formatting issues in some markdown renderers. Consider consolidating the sentence into a single paragraph.
    Unless your inquiry is regarding a [security vulnerability](SECURITY.md) or other sensitive matter, please do not 

docs/SECURITY.md:9

  • [nitpick] Presenting the supported versions as a continuous paragraph may reduce clarity. Consider using a table or bullet list format to clearly delineate the version information.
Currently, there are two supported versions of the package: the v2 package (pfSense-pkg-RESTAPI) and the legacy v1 package (pfSense-pkg-API). The v2 package is the latest version of the package and is actively developed and fully maintained. The legacy v1 package is no longer actively developed and is only receiving compatibility fixes and critical security updates when necessary. It is highly recommended to regularly update to the latest version of the package to ensure you are receiving important bug fixes and security updates.

@jaredhendrickson13 jaredhendrickson13 merged commit 12d31bf into master Mar 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants