BindZone fields are of incorrect type

[sponte]

Describe the bug
The refresh, retry, expire and minimum fields are currently defined as IntegerFields, but in reality, bind supports tokens such as 2h, 4d and so on, and therefore integer conversion does not work.

To Reproduce
Try to create any zone using /api/v2/services/bind/zone endpoint.

Expected behavior
The zone gets created

Screenshots or Response
The API responds with invalid field type error:

│ Error: unexpected response code '500': {"code":500,"status":"internal server error","response_id":"INTEGER_FIELD_WITH_NON_INTEGER_INTERNAL_VALUE","message":"Cannot parse IntegerField `refresh` from internal because its internal value is not\n                    a numeric value. Consider changing this field to a StringField.","data":[]}

pfSense Version & Package Version:

• pfSense Version: [e.g. pfSense 2.7.2]
• Package Version [e.g. v2.3.2]

Affected Endpoints:

• URL: [e.g. /api/v2/sevices/bind]

[jaredhendrickson13]

Thanks for pointing this out. Seems like an oversight on my end. I can get these switched over to StringField's but it'll need to be in v2.4.0 since it can break existing integrations.

[sponte]

Nice one! Sounds like a plan

[sponte]

Hello @jaredhendrickson13 - while working with the API, I also noticed that If I create a new zone (in my case I'm creating a forwarding zone (I'm using terraform), the zone does get created in the UI, but it does not make it into named.conf file, until I go into pfsense and save either the zone or the settings in the web portal - I tried calling apply, restarting the named service via the API, but none of them allow the zone to be propagated:

resource "restapi_object" "router_dns_forwarder" {
  provider  = restapi.pfsense
  path      = "/api/v2/services/bind/zone"
  read_path = "/api/v2/services/bind/zone?id={id}"
  data = jsonencode({
    disabled    = false,
    name        = local.dns_zone,
    description = "DNS Forwarding zone for ${local.dns_zone}",
    type        = "forward",
    view = [
      "LAN"
    ],
    forwarders = [
      ipam_allocate.compute_network.hosts["dns"].ip
    ],
    records = []
  })
}

Let me know if you'd like a new issue to be created for this.

[jaredhendrickson13]

Go ahead and open a separate issue for that one. Include some steps to reproduce and I can dig a little deeper into it.