Unicode Decoding in String/Char Literal Evaluation#114
Open
morris821028 wants to merge 6 commits intopejobo:v2.1from
Open
Unicode Decoding in String/Char Literal Evaluation#114morris821028 wants to merge 6 commits intopejobo:v2.1from
morris821028 wants to merge 6 commits intopejobo:v2.1from
Conversation
Do not affect the comment code, which has the windows filename or other.
Owner
|
Thanks,I'll look into this later on. I will close pull request #113 now. |
added 3 commits
May 27, 2019 13:25
Target case is inner class access. This change enhance the exception handling to get 30% performance improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is used to avoid the content of comment make it failed in parser. According to #112 , there is a solution which move the unicode decode part of
readchar()intostringSetupandcharSetup.Maybe we should limit some syntax problem. Please look at https://stackoverflow.com/questions/30727515/why-is-executing-java-code-in-comments-with-certain-unicode-characters-allowed
So, we don't want to parse the beanshell script as follows:
decode above script, and then execute as follows:
Summary, in this pull request