Unicode Decoding in String/Char Literal Evaluation by morris821028 · Pull Request #113 · pejobo/beanshell2

morris821028 · 2018-04-18T03:55:29Z

This patch is used to avoid the content of comment make it failed in parser. According to #112 , there is a solution which move the unicode decode part of readchar() into stringSetup and charSetup.

Improve error message for method invocation on null.

2.2b0 -> 2.2.0

ScriptEngineFactory should not advertise support for java

* added old code (parse java source if existent and class file is not found) but with switch * default is switched off * switch on by ** api call -> Interpreter.setCompatibility(true) ** system property -> -Dbsh.compatibility=true

…g a script without local member declaration

…to string, and can not be successfully retrieved by outer layers

corrected junit library version number in eclipse .classpath file Fix provided by Andrea Curtoni

prevent obsolete calls to "j.l.reflect.AccessibleObject.setAccessible(true)"

…scope

pejobo · 2018-04-18T16:08:36Z

Thanks for making a pull request! This reminds me to add a "code of conduct", still on my buckt list :(

Two things before I proceed:

The pull request should be for branch v2.1, not master
I intend to change the licence to Apache-2, so please withdraw your pull request if you do not agree that your code is made available under this licence (see Licence change: LGPL to Apache-2 #110)

Another thing - do you know this repro: https://github.com/beanshell/beanshell?

pejobo · 2018-04-18T16:16:15Z

tests/junitTests/src/bsh/StringLiteralTest.java

+	public void parse_unicode_literals_in_comment() throws Exception {
+		final Interpreter interpreter = new Interpreter();
+		Object result = interpreter.eval("// source path: C:\\user\\desktop");
+		Assert.assertEquals(result, null);


Test case one (dedicated method)

pejobo · 2018-04-18T16:16:36Z

tests/junitTests/src/bsh/StringLiteralTest.java

+		Object result = interpreter.eval("// source path: C:\\user\\desktop");
+		Assert.assertEquals(result, null);
+		char c = (char) interpreter.eval("return '\\u51ea\'");
+		Assert.assertEquals(c, '\u51ea');


Test case two (dedicated method)

pejobo · 2018-04-18T16:16:57Z

tests/junitTests/src/bsh/StringLiteralTest.java

+		Assert.assertEquals(c, '\u51ea');
+		String s = (String) interpreter.eval("return \"\\u51EA1234\"; // \\user\\desktop");
+		System.out.println(s);
+		Assert.assertEquals(s, "\u51EA1234");


Test case three (dedicated method)

morris821028 · 2018-04-19T00:02:02Z

Yeah, I know the repo https://github.com/beanshell/beanshell . Therefore, I also opened the issue about it. There are many enhancement in other repo than this one. But, this one has a large version number of release product. I don't know what this repo has, but anthoer don't. Our product uses 2.1.x version, so there is a problem to update.

Althrough @stain, @nickl- , etc. fixed some bugs in their repo, I prefer this repo to work with Eclipse IDE. It has more convenient to develop, experiment and build.

If all of you can decide how to merge into a repository, and create a complete environment for build flow and introduce what's kind of IDE you used, it will be more maintainers I think.

morris821028 · 2018-04-19T01:58:19Z

Maybe we should limit some syntax problem. Please look at https://stackoverflow.com/questions/30727515/why-is-executing-java-code-in-comments-with-certain-unicode-characters-allowed

pejobo · 2018-04-20T06:50:55Z

Superseded by #114

nickl- · 2018-04-21T17:20:22Z

@morris821028 pong!

Missed this thread but perhaps #110 is more appropriate for a response from me. @pejobo please see response there...

pejobo70@googlemail.com and others added 27 commits October 20, 2011 18:59

SVN trunk now is for upcoming v2.2 release

63e44ba

test case for issue #60

9e6ed9e

fixes issue#57

c95061d

fixes issue#67

c53f3c8

Fix some compiler warnings.

c51542b

Improve error message for method invocation on null.

Issue 72

21650ca

2.2b0 -> 2.2.0

Issue 73

951b52e

ScriptEngineFactory should not advertise support for java

test case for issue#24

1576ffa

issue#17

762e606

* added old code (parse java source if existent and class file is not found) but with switch * default is switched off * switch on by ** api call -> Interpreter.setCompatibility(true) ** system property -> -Dbsh.compatibility=true

fixes issue#69

a22dbfb

fixes issue#66

102e80e

issue #77: NullPointerException by calling getAllNames() after parsin…

bbab002

…g a script without local member declaration

issue #79. Root cause exception in class initialization is converted …

ed8801f

…to string, and can not be successfully retrieved by outer layers

Issue #82: unary operation (++/--) fails on float/double type.

da29288

fixes issue#85

9413c50

corrected junit library version number in eclipse .classpath file Fix provided by Andrea Curtoni

issue #88

4df454b

prevent obsolete calls to "j.l.reflect.AccessibleObject.setAccessible(true)"

Create README.md

d52c659

documentation updates

7991663

fixed issue links

407bfc4

release 2.19

159c4ea

release 2.1.9

5c2393e

remove release-candidate jar

9d07af0

fixed release date

0ed0336

Add .gitignore

0893c3c

String/Char Literal: decode unicode in specific scope, not in global …

2650af7

…scope

String/Char Literal: add test cases

de86211

Update .gitignore

375c1d9

pejobo reviewed Apr 18, 2018

View reviewed changes

morris821028 changed the base branch from master to v2.1 April 19, 2018 11:22

pejobo mentioned this pull request Apr 20, 2018

Unicode Decoding in String/Char Literal Evaluation #114

Open

pejobo closed this Apr 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Unicode Decoding in String/Char Literal Evaluation#113

Unicode Decoding in String/Char Literal Evaluation#113
morris821028 wants to merge 27 commits intopejobo:v2.1from
morris821028:master

morris821028 commented Apr 18, 2018

Uh oh!

pejobo commented Apr 18, 2018

Uh oh!

pejobo Apr 18, 2018

Uh oh!

pejobo Apr 18, 2018

Uh oh!

pejobo Apr 18, 2018

Uh oh!

morris821028 commented Apr 19, 2018

Uh oh!

morris821028 commented Apr 19, 2018

Uh oh!

pejobo commented Apr 20, 2018

Uh oh!

nickl- commented Apr 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

morris821028 commented Apr 18, 2018

Uh oh!

pejobo commented Apr 18, 2018

Uh oh!

pejobo Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

pejobo Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

pejobo Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

morris821028 commented Apr 19, 2018

Uh oh!

morris821028 commented Apr 19, 2018

Uh oh!

pejobo commented Apr 20, 2018

Uh oh!

nickl- commented Apr 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants