Skip to content

fix(async search): recover frac search #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
forshev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(async search): recover frac search #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion asyncsearcher/async_searcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,13 @@ func compressQPR(qpr *seq.QPR, cb func(compressed []byte) error) error {
return nil
}

func (as *AsyncSearcher) processFrac(f frac.Fraction, info asyncSearchInfo) error {
func (as *AsyncSearcher) processFrac(f frac.Fraction, info asyncSearchInfo) (err error) {
defer func() {
if panicData := util.RecoverToError(recover(), asyncSearchPanics); panicData != nil {
err = fmt.Errorf("async search panic during processFrac: %w", panicData)
}
}()

qpr, err := f.Search(info.ctx, info.Request.Params)
if err != nil {
return err
Expand Down
6 changes: 6 additions & 0 deletions asyncsearcher/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,10 @@ var (
Name: "read_only",
Help: "Indicates if store is in async search read-only mode (can not start a new async search) due to disk usage limits",
})
asyncSearchPanics = promauto.NewCounter(prometheus.CounterOpts{
Namespace: "seq_db_store",
Subsystem: "async_search",
Name: "panics_total",
Help: "Number of panics in async search",
})
)
Loading