Skip to content

fix(async search): recover frac search#342

Open
forshev wants to merge 1 commit intomainfrom
0-async-search-recover-process-frac-panic
Open

fix(async search): recover frac search#342
forshev wants to merge 1 commit intomainfrom
0-async-search-recover-process-frac-panic

Conversation

@forshev
Copy link
Contributor

@forshev forshev commented Feb 2, 2026

Description

Handle panics during frac search in async searches
Add async search panics metric


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Bitmask-4 174405 ef3059
0.00 B/op 3.00 B/op NaN 🔴
FindSequence_Random/medium-4 174405 ef3059
11839.40 MB/s 10315.58 MB/s 0.87 🔴
86.49 ns/op 99.27 ns/op 1.15 🔴
FindSequence_Random/small-4 174405 ef3059
10280.15 MB/s 4344.58 MB/s 0.42 🔴
24.90 ns/op 58.92 ns/op 2.37 🔴
GenerateDocs-4 174405 ef3059
952.20 ns/op 1142.00 ns/op 1.20 🔴
ProcessDocuments-4 174405 ef3059
381.00 B/op 33319.00 B/op 87.45 🔴
4.00 allocs/op 5.00 allocs/op 1.25 🔴

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.48%. Comparing base (1744059) to head (010a4c7).

Files with missing lines Patch % Lines
asyncsearcher/async_searcher.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   71.65%   71.48%   -0.17%     
==========================================
  Files         204      204              
  Lines       14770    14773       +3     
==========================================
- Hits        10583    10561      -22     
- Misses       3435     3453      +18     
- Partials      752      759       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@forshev forshev added this to the v0.66.0 milestone Feb 2, 2026
asyncSearchPanics = promauto.NewCounter(prometheus.CounterOpts{
Namespace: "seq_db_store",
Subsystem: "async_search",
Name: "panics",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Counters must end with _total

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed it

@forshev forshev force-pushed the 0-async-search-recover-process-frac-panic branch from 719426e to 010a4c7 Compare February 2, 2026 12:42
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/medium-4 174405 898402
11839.40 MB/s 10328.72 MB/s 0.87 🔴
86.49 ns/op 99.14 ns/op 1.15 🔴
FindSequence_Random/small-4 174405 898402
10280.15 MB/s 5417.91 MB/s 0.53 🔴
24.90 ns/op 47.25 ns/op 1.90 🔴
ProcessDocuments-4 174405 898402
381.00 B/op 33192.00 B/op 87.12 🔴
4.00 allocs/op 5.00 allocs/op 1.25 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants