Skip to content

impl Send for VmInstanceRoT safely #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flihp merged 3 commits into from
Mar 21, 2026
Merged

impl Send for VmInstanceRoT safely #57

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0c20e4
Make VmInstanceRot require Send
jordanhendricks Mar 20, 2026
44caf28
do it safely not unsafely
iximeow Mar 21, 2026
5e537c5
rustfmt
iximeow Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/rot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,15 @@ pub enum VmInstanceRotError {

/// This type mocks the `propolis` process that backs a VM.
pub struct VmInstanceRot {
oxattest_mock: Box<dyn OxAttest>,
oxattest_mock: Box<dyn OxAttest + Send>,
log: VmInstanceConf,
}

unsafe impl Send for VmInstanceRot {}

impl VmInstanceRot {
pub fn new(oxattest_mock: Box<dyn OxAttest>, log: VmInstanceConf) -> Self {
pub fn new(
oxattest_mock: Box<dyn OxAttest + Send>,
log: VmInstanceConf,
) -> Self {
Self { oxattest_mock, log }
}
}
Expand Down
Loading