Merged
Conversation
Collaborator
|
I'm working w/ this code today. Since it's the weekend & I don't expect others to be online, I'm gonna squash and merge pretty quickly to keep the cherry-picking / rebasing to a minimum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this does #55 but differently: @jordanhendricks noticed this earlier today as her
mainwas a bit older than that commit, and the approach she'd taken is one we should go with.I think the patches she'd written up for vm-attest are good to land, but I think she wanted to see them working propolis-side before doing PRs. this one's important enough I'm cutting the line, sorry Jordan :)
the
unsafe impl Sendhere is very dangerous. since this code ends up in propolis, ifVmInstanceRotwas created with anOxAttestthat is not Send, that's the pathway to a guest VM escape. really really bad. we need to not do that. adding+ Sendbounds gets Rust to check this stuff and gives a type error if code would have done something unsound.