feat: add photo-addon extension with E2E tests and UX improvements #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement viewport-based prefetching for map thumbnails (only loads visible markers) - Fix lightbox scrollbar by increasing panel height reservation from 200px to 270px - Replace lightbox thumbnail preview with loading spinner (removes jittery transition) - Remove unused preview cache and thumbnail fetching code - Fix linter warnings (unused imports, accessibility eslint-disable comments) - Add test-and-commit.sh script for CI validation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add Playwright E2E test suites for both extensions: Photo Addon tests: - Photo gallery loading and display - Lightbox viewer functionality - Map view with Leaflet integration - Date grouping and navigation Advanced Search tests: - Search functionality and filters - Filter panel and KQL input - Saved searches management - View modes and responsive behavior Also includes: - Test fixtures with authentication helpers - Global setup for oCIS login - Updated playwright.config.ts with project configs - Updated .gitignore for auth state files - BACKLOG.md moved to respective packages Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
@paul43210 can you sync your fork and then do a rebase of your branches and then push them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-submission of the photo-addon extension (originally PR #305) with additional improvements:
Changes Since Original PR
63ed9285ce0761Features
Test Plan
pnpm test:unit --filter photo-addonpnpm test:e2e --project=photo-addon🤖 Generated with Claude Code