Add photo-addon extension (retry)

[mmattel]

Based on the work of @paul43210

Referencing: #305 (feat: add advanced-search extension)
Referencing: #308 (Drone issues after merging in: advanced-search extension)

Note that another PR for the other reverted extension will be created independently.

Because drone had a hickup in the original PR #305, it simply did not run but showed green, we had to revert the merge because it was blocking all other drone runs. With this PR we recreate it.

This PR also includes:

• added relevant parts of the orphaned commit referenced in Drone issues after merging in: photo-addon extension #308 with some fixes.
• incorporated changes to remove as many warnings from the original drone run as possible.
  Note that I was not able to take a closer look into errors reported @LukasHirt

Note that we have to merge this PR first, then create or rebase the upcoming PR for the advanced search extension and add changes on commonly used files such as in the script folder.

[paul43210]

Sorry, new PR created:

#312

The PR includes:

• Both commits (63ed928 and 5ce0761) with map optimizations, lightbox UX fixes, and E2E tests
• A summary explaining this is a re-submission of PR feat: add photo-addon extension #305 with improvements
• A detailed test plan for reviewers

[mmattel]

@paul43210 many thanks, seen that, the underlaying issue not your fault... added a comment in your resubmitted PR.
Note that I needed to adapt some code here to eliminate warnings, but some errors still remain. I hope that @LukasHirt can help to fix them. AI coding causes a lot of overhead that needs to be fixed manually 😢 You would have seen that if the CI would have run properly. You can take a look on the CI here and see which errors are blocking. If you have solutions, you are welcomed add commits...

[paul43210]

Hi @mmattel,

First, I want to apologize for the confusion with the multiple PRs. This is my first contribution to the ownCloud project and I'm still learning the workflow and processes here. I really appreciate your patience in dealing with the CI issues and helping to get this sorted out.

I took a look at the CI failures you mentioned and identified the specific issues:

Errors (12) in PhotoLightbox.vue

• Lines 2, 65: Non-interactive elements with click handlers need keyboard listeners
• Line 14: Elements with role="menu" must be focusable
• Lines 15, 19, 23, 28: @mouseenter/@mouseleave need corresponding @focus/@blur handlers

Warnings (28)

• Unused variables: err, event, e, CLUSTER_RADIUS_METERS, formatSize, groupModes, etc.
• Unused functions: changeGroupMode, extractExifDateTime, unobservePhoto, etc.

---

I believe these are all fixed in PR #312, which passes lint cleanly. The fixes were in commits 63ed928 and 5ce0761.

I'm happy to help however works best for your workflow - whether that's cherry-picking fixes onto this branch, or any other approach you prefer. Just let me know what would be most helpful and I'll do my best to assist.

Again, sorry for any extra work this has caused, and thank you for your guidance.

[mmattel]

You are Welcomed 😃
The next steps will be earliest on Monday, there we can take a closer look why full CI did not run. If this gets sorted out, we can retrigger CI including drone and improve on issues.
We were under full load last week because we were in the process for an ocis release candidate 8.0.rc1. We were happy that your first ocis PR got merged and I hope we can sneak in the second one into rc1 because it is not a code change - if the two extensions are working as expected. Otherwise it will "only" be merged to ocis master and available for the next release.

[CLAassistant]

All committers have signed the CLA.