Restructure Project Core #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new JavaScript callback 'reorderBookmarks' to allow reordering of bookmarks from the UI. The callback parses a JSON array of bookmark IDs and updates the bookmark store accordingly.
Introduces a 'position' field to bookmarks for ordering items on the bookmark bar. Bookmarks added to the bar are assigned the next available position, and bar items are now sorted by position. Adds ReorderBookmarks to update positions based on a given order, and updates JSON serialization/deserialization to include the position field.
Implements drag-and-drop functionality for bookmark items, allowing users to reorder bookmarks in the bar. Adds related CSS styles and event handlers for drag state, touch/mouse long press, and order persistence via saveBookmarkOrder.
Replaces the previous HTML5 drag-and-drop API with a custom mouse-based drag-and-drop implementation for bookmark items. Improves visual feedback, adds left/right drop indicators, and ensures better compatibility and control over drag behavior. Also prevents accidental navigation during drag and refines the UI for drag states.
Enhanced bookmark interaction: middle mouse button and Ctrl+click now open bookmarks in a new tab using a native bridge if available, otherwise falling back to navigation in the current tab.
Introduces a new bookmarks.html file with UI and JavaScript for displaying, managing, and clearing bookmarks. The page includes styling, favicon support, and integration with window methods for bookmark operations.
Introduces a Bookmarks entry to the menu with Ctrl+B shortcut and corresponding action handler for opening bookmarks in a new tab.
Introduces OnOpenBookmarksNewTab to allow opening the bookmarks page in a new tab via JavaScript callback binding. This aligns bookmarks behavior with history, downloads, passwords, and extensions.
Added 'Ctrl+B' to shortcuts.json to enable quick access to bookmarks.
Introduces a new shortcut action 'open-bookmarks' that opens the bookmarks page in a new tab. This enhances user accessibility to bookmarks via shortcuts.
Introduces a new JavaScript callback, JS_UpdateBookmark, allowing bookmarks to be updated from the UI while preserving favicon and show_in_bar settings. Updates the Tab class to expose this functionality to the global JS context.
Renamed variables and comments from 'show_in_bar' and 'favicon_url' to 'show_on_bar' and 'favicon' to match the updated bookmark data structure and improve code clarity.
Replaces trailing whitespace with consistent formatting in build-linux.yml and build-macos.yml workflow files. No functional changes; improves script readability and consistency.
Updated @Keyframes and @-webkit-keyframes blocks in multiple HTML and CSS files for improved readability and consistency. Reformatted inline SVG elements for better maintainability and accessibility. No functional changes; this is a code style and formatting update.
Cleaned up unnecessary trailing whitespace throughout the CMakeLists.txt file to improve code readability and maintain consistency.
Consistently reformats code in BookmarkStore, DownloadManager, PasswordManager, and related headers for improved readability and maintainability. Changes include standardized spacing, indentation, brace placement, and lambda formatting. No functional logic changes are introduced.
Introduces a theme system including ThemeManager (C++), theme selection UI (themes.html), and built-in themes (dark, light, midnight, monokai, nord). Updates menu to support theme management, adds theme assets and documentation, and integrates theme logic into UI components.
Introduces a GitHub Actions workflow for building the project on Windows ARM64EC. The workflow supports SDK auto-detection, caching, installer creation, and configurable build options for development and clean builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.