Skip to content

Lyrical testing docker images#877

Merged
mikaelarguedas merged 3 commits into
masterfrom
lyrical_testing
May 8, 2026
Merged

Lyrical testing docker images#877
mikaelarguedas merged 3 commits into
masterfrom
lyrical_testing

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Contributor

@mikaelarguedas mikaelarguedas commented May 8, 2026

Using templates from osrf/docker_templates#119

Same strategy as for Jazzy (#741) :

  • Provide Lyrical docker images for the testing phase before official release
  • Publish these images (based on the testing apt repo) to dockerhub
  • not add them to CI
  • not move the latest tag

At official Lyrical releaste time:

  • regenerate the images pointing to the right repo
  • move the latest tag
  • submit to dockerhub for rebuild
  • enable CI

Alternative to #876

Main differences:

  • Do not mix rolling and lyrical changes
  • Do not enable CI
  • Do not move the latest tag

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
Copy link
Copy Markdown
Contributor Author

To increase probability of this being accepted / built on dockerhub over the weekend I'll merge this as is and address suggestion / improvements / alternatives in a follow-up PR

@mikaelarguedas mikaelarguedas merged commit 5b89ba9 into master May 8, 2026
@mikaelarguedas mikaelarguedas deleted the lyrical_testing branch May 8, 2026 18:14
@mikaelarguedas
Copy link
Copy Markdown
Contributor Author

nice timing @ruffsl :)

@ruffsl
Copy link
Copy Markdown
Member

ruffsl commented May 8, 2026

I was building a local checkout just to verify and it passed as you posted your comment, haha!

@tfoote
Copy link
Copy Markdown
Contributor

tfoote commented May 11, 2026

Thanks both. For the roll out of production we've been discussing pushing to main with the release candidate which would allow us to switch to the main version and be live got the official release.

@mikaelarguedas
Copy link
Copy Markdown
Contributor Author

Thanks both. For the roll out of production we've been discussing pushing to main with the release candidate which would allow us to switch to the main version and be live got the official release.

Awesome, once the decision / change is in effect how would one be notified about it (this way we can make the change on this repo).

@tfoote
Copy link
Copy Markdown
Contributor

tfoote commented May 21, 2026

Hopefully we'd ping you but, the decision was not to do it in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants