Add Lyrical Luth dockerfiles#876
Conversation
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
@skyegalaxy lgtm, but i would like to have 2nd review before merge on this.
|
CI failures are the same thing I ran into when running the dockerfile generation script, in that the packages aren't available in ros2 but they are in ros2-testing |
|
When is the planned release/sync date for Lyrical ? Indeed the packages are not sync just yet. Details |
|
The target release date is May 22. It looks like previously when the images were available before the packages were officially released, we could point the apt sources to temporarily use ros2-testing. The method for getting the package sources appears to have changed, so I'm not sure how much of a lift it'd be to get the packages available in these containers early. If we could that'd be great as it'd be really helpful during the T&T party. Maybe @tfoote or @cottsay has some ideas? |
Co-authored-by: Scott K Logan <logans@cottsay.net>
|
thanks @cottsay! I'm not a maintainer of this repo so could someone else please approve the CI workflow? |
|
hmm, CI still fails because it's using the templates to generate and check the dockerfiles. perhaps we need to swap out for one of the |
|
closed in favor of #877 |
Also rolls rolling to resolute.
Note: needed to modify
docker_templates/packages.pypackage repository url to point toros2-testinginstead ofros2in order to get autogenerated dockerfiles to work