Skip to content

Add Lyrical Luth dockerfiles#876

Closed
skyegalaxy wants to merge 4 commits into
osrf:masterfrom
skyegalaxy:skyegalaxy/add-lyrical
Closed

Add Lyrical Luth dockerfiles#876
skyegalaxy wants to merge 4 commits into
osrf:masterfrom
skyegalaxy:skyegalaxy/add-lyrical

Conversation

@skyegalaxy
Copy link
Copy Markdown

@skyegalaxy skyegalaxy commented May 6, 2026

Also rolls rolling to resolute.

Note: needed to modify docker_templates/packages.py package repository url to point to ros2-testing instead of ros2 in order to get autogenerated dockerfiles to work

Skyler Medeiros added 3 commits May 6, 2026 14:48
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Copy link
Copy Markdown

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyegalaxy lgtm, but i would like to have 2nd review before merge on this.

@skyegalaxy
Copy link
Copy Markdown
Author

skyegalaxy commented May 6, 2026

CI failures are the same thing I ran into when running the dockerfile generation script, in that the packages aren't available in ros2 but they are in ros2-testing

Traceback (most recent call last):
  File "/home/runner/work/docker_images/docker_images/.ci/ci_script.py", line 279, in <module>
    main()
    ~~~~^^
  File "/home/runner/work/docker_images/docker_images/.ci/ci_script.py", line 127, in main
    create_dockerfiles.main(('dir', '-d' + hub_tag_dir))
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/docker_images/docker_images/ros/create_dockerfiles.py", line 58, in main
    expandPackages(data)
    ~~~~~~~~~~~~~~^^^^^^
  File "/opt/hostedtoolcache/Python/3.14.4/x64/lib/python3.14/site-packages/docker_templates/packages.py", line 152, in expandPackages
    package_versions = getPackageVersions(data, package_index, data[package_type], package_type)
  File "/opt/hostedtoolcache/Python/3.14.4/x64/lib/python3.14/site-packages/docker_templates/packages.py", line 112, in getPackageVersions
    package_info = getPackageInfo(package_pattern, package_index)
  File "/opt/hostedtoolcache/Python/3.14.4/x64/lib/python3.14/site-packages/docker_templates/packages.py", line 79, in getPackageInfo
    package_info = matchs.group(0)
                   ^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'group'

@ruffsl
Copy link
Copy Markdown
Member

ruffsl commented May 7, 2026

When is the planned release/sync date for Lyrical ? Indeed the packages are not sync just yet.

Details
d/r/l/u/resolute (skyegalaxy/add-lyrical)> , make build
[+] Building 29.9s (9/10)                                                                                                                    docker:default
 => [internal] load build definition from Dockerfile                                                                                                   0.0s
 => => transferring dockerfile: 1.42kB                                                                                                                 0.0s
 => [internal] load metadata for docker.io/library/ubuntu:resolute                                                                                     0.9s
 => [internal] load .dockerignore                                                                                                                      0.0s
 => => transferring context: 2B                                                                                                                        0.0s
 => [internal] load build context                                                                                                                      0.0s
 => => transferring context: 143B                                                                                                                      0.0s
 => [1/6] FROM docker.io/library/ubuntu:resolute@sha256:f3d28607ddd78734bb7f71f117f3c6706c666b8b76cbff7c9ff6e5718d46ff64                               4.0s
 => => resolve docker.io/library/ubuntu:resolute@sha256:f3d28607ddd78734bb7f71f117f3c6706c666b8b76cbff7c9ff6e5718d46ff64                               0.0s
 => => sha256:f3d28607ddd78734bb7f71f117f3c6706c666b8b76cbff7c9ff6e5718d46ff64 6.69kB / 6.69kB                                                         0.0s
 => => sha256:d31acef2a964b6df1f2b7e20a1525c4f2378024e087a4f8a8a9a4247e6a79573 1.39kB / 1.39kB                                                         0.0s
 => => sha256:30ba44506a6d003153c80023c4474e67d3487e9178df254bde55b19209cc8683 4.38kB / 4.38kB                                                         0.0s
 => => sha256:6f5c5aa4e145204b113f983c003ff8ad6489394294ef95ec030bc94e3daded54 41.55MB / 41.55MB                                                       0.6s
 => => sha256:1c24335ddd46023ff99bd665bd8ea6798464f7bbf501718edcf2eb4696e5f408 387B / 387B                                                             0.2s
 => => extracting sha256:6f5c5aa4e145204b113f983c003ff8ad6489394294ef95ec030bc94e3daded54                                                              3.1s
 => => extracting sha256:1c24335ddd46023ff99bd665bd8ea6798464f7bbf501718edcf2eb4696e5f408                                                              0.0s
 => [2/6] RUN echo 'Etc/UTC' > /etc/timezone &&     ln -s /usr/share/zoneinfo/Etc/UTC /etc/localtime &&     apt-get update &&     apt-get install -q   3.5s
 => [3/6] RUN apt-get update && apt-get install -q -y --no-install-recommends     ca-certificates     curl     dirmngr     gnupg2     && rm -rf /var  16.1s 
 => [4/6] RUN curl -L -s -o /tmp/ros2-apt-source.deb https://github.com/ros-infrastructure/ros-apt-source/releases/download/1.2.0/ros2-apt-source_1.2  3.1s 
 => ERROR [5/6] RUN apt-get update && apt-get install -y --no-install-recommends     ros-lyrical-ros-core=0.13.0-3*     && rm -rf /var/lib/apt/lists/  2.2s 
------                                                                                                                                                      
 > [5/6] RUN apt-get update && apt-get install -y --no-install-recommends     ros-lyrical-ros-core=0.13.0-3*     && rm -rf /var/lib/apt/lists/*:            
0.323 Get:1 http://packages.ros.org/ros2/ubuntu resolute InRelease [4655 B]                                                                                 
0.342 Get:2 http://security.ubuntu.com/ubuntu resolute-security InRelease [136 kB]                                                                          
0.362 Get:3 http://packages.ros.org/ros2/ubuntu resolute/main Sources [34.8 kB]                                                                             
0.402 Get:4 http://packages.ros.org/ros2/ubuntu resolute/main amd64 Packages [27.2 kB]                                                                      
0.409 Get:5 http://security.ubuntu.com/ubuntu resolute-security/universe amd64 Packages [40.9 kB]
0.425 Get:6 http://security.ubuntu.com/ubuntu resolute-security/main amd64 Packages [30.1 kB]
0.453 Get:7 http://archive.ubuntu.com/ubuntu resolute InRelease [136 kB]
0.612 Get:8 http://archive.ubuntu.com/ubuntu resolute-updates InRelease [136 kB]
0.776 Get:9 http://archive.ubuntu.com/ubuntu resolute-backports InRelease [136 kB]
0.842 Get:10 http://archive.ubuntu.com/ubuntu resolute/main amd64 Packages [1874 kB]
0.883 Get:11 http://archive.ubuntu.com/ubuntu resolute/universe amd64 Packages [20.1 MB]
1.046 Get:12 http://archive.ubuntu.com/ubuntu resolute/restricted amd64 Packages [189 kB]
1.047 Get:13 http://archive.ubuntu.com/ubuntu resolute/multiverse amd64 Packages [352 kB]
1.054 Get:14 http://archive.ubuntu.com/ubuntu resolute-updates/universe amd64 Packages [40.9 kB]
1.069 Get:15 http://archive.ubuntu.com/ubuntu resolute-updates/restricted amd64 Packages [34.7 kB]
1.069 Get:16 http://archive.ubuntu.com/ubuntu resolute-updates/main amd64 Packages [73.6 kB]
1.426 Fetched 23.4 MB in 1s (19.2 MB/s)
1.426 Reading package lists...
1.736 Reading package lists...
2.042 Building dependency tree...
2.103 Reading state information...
2.112 E: Unable to locate package ros-lyrical-ros-core
------
Dockerfile:36
--------------------
  35 |     # install ros2 packages
  36 | >>> RUN apt-get update && apt-get install -y --no-install-recommends \
  37 | >>>     ros-lyrical-ros-core=0.13.0-3* \
  38 | >>>     && rm -rf /var/lib/apt/lists/*
  39 |     
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c apt-get update && apt-get install -y --no-install-recommends     ros-lyrical-ros-core=0.13.0-3*     && rm -rf /var/lib/apt/lists/*" did not complete successfully: exit code: 100
make: *** [Makefile:13: build] Error 1

@skyegalaxy
Copy link
Copy Markdown
Author

The target release date is May 22. It looks like previously when the images were available before the packages were officially released, we could point the apt sources to temporarily use ros2-testing. The method for getting the package sources appears to have changed, so I'm not sure how much of a lift it'd be to get the packages available in these containers early. If we could that'd be great as it'd be really helpful during the T&T party. Maybe @tfoote or @cottsay has some ideas?

Comment thread ros/lyrical/ubuntu/resolute/ros-core/Dockerfile Outdated
Co-authored-by: Scott K Logan <logans@cottsay.net>
@skyegalaxy
Copy link
Copy Markdown
Author

thanks @cottsay! I'm not a maintainer of this repo so could someone else please approve the CI workflow?

@skyegalaxy
Copy link
Copy Markdown
Author

hmm, CI still fails because it's using the templates to generate and check the dockerfiles. perhaps we need to swap out for one of the testing templates?

@mikaelarguedas
Copy link
Copy Markdown
Contributor

Great !

If useful I opened a similar PR here: #877 and confirmed all images build and can run a talker listener

I followed the same strategy as for Jazzy tutorial party: #741

If ok for you I'll submit them to the official docker library later in the day

@skyegalaxy
Copy link
Copy Markdown
Author

closed in favor of #877

@skyegalaxy skyegalaxy closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants