-
Notifications
You must be signed in to change notification settings - Fork 0
[#318] 네트워크 연결이 끊겼을 떄 컨텐츠를 추가 및 수정하지 못하도록 막는다 #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
opficdev
merged 5 commits into
develop
from
feat/#318-network-disconnected-block-add-todo
Mar 29, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bd9a7e5
feat: HomeView에서 네트워크가 끊어지면 컨텐츠를 추가하는 버튼을 잠금
opficdev b398b00
feat: SettingsView에서 네트워크가 끊어지면 서버와 연관된 버튼들은 비활성화
opficdev 43d10eb
feat: 테마뷰에서 네트워크가 끊어지면 업데이트 불가능하도록 추가
opficdev 12bcaeb
remove: 테마는 disabled 제거
opficdev 83718a6
feat: 프로필 쪽 네트워크를 감지하여 상태 메시지 잠금
opficdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setupNetworkObserving()함수와 관련 로직이HomeViewModel,ProfileViewModel,SettingViewModel에 중복되어 있습니다. 코드 중복은 유지보수성을 저하시킬 수 있으므로, 이 로직을 공통 프로토콜과 확장(extension)으로 추출하는 리팩토링을 고려해보세요.예를 들어, 네트워크 상태를 관찰하고
networkStatusChanged액션을 보내는 로직을 담은 프로토콜을 만들어 채택하도록 하면, 각 ViewModel에서 중복 코드를 제거하고 코드 재사용성을 높일 수 있습니다.