[#318] 네트워크 연결이 끊겼을 떄 컨텐츠를 추가 및 수정하지 못하도록 막는다#329
Merged
Conversation
Owner
opficdev
commented
Mar 29, 2026
opficdev
commented
- closed 네트워크 연결이 끊겼을 때, 컨텐츠를 추가하지 못하도록 막는다 #318
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 ObserveNetworkConnectivityUseCase를 도입하여 앱 전반의 네트워크 연결 상태를 감지하고, 오프라인 상태일 때 UI 상호작용을 제한하는 기능을 구현했습니다. HomeViewModel, ProfileViewModel, SettingViewModel에 중복 구현된 네트워크 관찰 로직을 공통 프로토콜이나 확장으로 추출하여 코드 중복을 제거하고 유지보수성을 높이라는 피드백이 제공되었습니다.
Comment on lines
+447
to
+455
| func setupNetworkObserving() { | ||
| networkConnectivityUseCase.observe() | ||
| .removeDuplicates() | ||
| .receive(on: DispatchQueue.main) | ||
| .sink { [weak self] isConnected in | ||
| self?.send(.networkStatusChanged(isConnected)) | ||
| } | ||
| .store(in: &cancellables) | ||
| } |
Contributor
There was a problem hiding this comment.
setupNetworkObserving() 함수와 관련 로직이 HomeViewModel, ProfileViewModel, SettingViewModel에 중복되어 있습니다. 코드 중복은 유지보수성을 저하시킬 수 있으므로, 이 로직을 공통 프로토콜과 확장(extension)으로 추출하는 리팩토링을 고려해보세요.
예를 들어, 네트워크 상태를 관찰하고 networkStatusChanged 액션을 보내는 로직을 담은 프로토콜을 만들어 채택하도록 하면, 각 ViewModel에서 중복 코드를 제거하고 코드 재사용성을 높일 수 있습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.