Improve script quality for base ibm-fusion-access step registry steps#74892
Open
amp-rh wants to merge 1 commit intoopenshift:mainfrom
Open
Improve script quality for base ibm-fusion-access step registry steps#74892amp-rh wants to merge 1 commit intoopenshift:mainfrom
amp-rh wants to merge 1 commit intoopenshift:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amp-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci-robot
added
the
rehearsals-ack
Standardize bash headers to `set -eux -o pipefail; shopt -s inherit_errexit`, replace echo with `: 'marker'` where set -x is active, replace sleep with oc wait, add FA__* env var prefixes, remove error suppression patterns, and update shared-lib with JUnit helper functions. These base steps are not currently referenced by any CI job. Co-authored-by: Cursor <cursoragent@cursor.com>
amp-rh
force-pushed
the
pr1-base-step-quality
branch
from
c13aefd to
7683483
Compare
Contributor
|
@amp-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -eux -o pipefail; shopt -s inherit_errexitacross all baseibm-fusion-access/step scriptsechowith: 'marker'whereset -xis active, replacesleepwithoc wait, addFA__*env var prefixes, and remove error suppression patternsshared-libwith JUnit helper functions (add_test_result,generate_junit_xml)Part 1 of 5 in the IBM Fusion Access CNV CI configuration series.
Made with Cursor