Improve script quality for interop-tests ibm-fusion-access steps#74893
Improve script quality for interop-tests ibm-fusion-access steps#74893amp-rh wants to merge 2 commits intoopenshift:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amp-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Standardize bash headers to `set -eux -o pipefail; shopt -s inherit_errexit`, replace echo with `: 'marker'` where set -x is active, replace sleep with oc wait, add FA__* env var prefixes, remove error suppression patterns, and update shared-lib with JUnit helper functions. These base steps are not currently referenced by any CI job. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply reviewer-requested improvements to all existing interop-tests ibm-fusion-access step scripts: standardize bash headers, replace echo with colon markers, use oc wait instead of sleep, add FA__* env var prefixes, remove error suppression, and update ref.yaml documentation. No new steps, deleted steps, or chain changes are included. Co-authored-by: Cursor <cursoragent@cursor.com>
amp-rh
force-pushed
the
pr2-interop-step-quality
branch
from
a08e60b to
e8044cf
Compare
|
@amp-rh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
interop-tests/ibm-fusion-access/step scriptsset -eux -o pipefail; shopt -s inherit_errexit), replaceechowith: 'marker', useoc waitinstead ofsleep, addFA__*env var prefixes, remove error suppression, and update ref.yaml documentationPart 2 of 5 in the IBM Fusion Access CNV CI configuration series.
Depends on: #74892
Made with Cursor