[release-4.21] OCPBUGS-69941: Add kubevirt platform to dual-stack supported platforms #2861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kubevirt platform in Hosted Control Planes (HCP) supports a dual-stack topology. Adding it to the dualStackPlatforms list to avoid reconciler error when the hosted cluster is dual-stack. Signed-off-by: Oren Cohen <ocohen@redhat.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-66417 has been cloned as Jira Issue OCPBUGS-69941. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
Contributor
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-69941, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
/retest |
1 similar comment
Contributor
|
/retest |
Contributor
|
@orenc1: This pull request references Jira Issue OCPBUGS-69941, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
Contributor
|
@orenc1: This pull request references Jira Issue OCPBUGS-69941, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yli2@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tssurya
approved these changes
Dec 23, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@orenc1 please add the verified label if you finished verification like you mentioned on slack: https://redhat-internal.slack.com/archives/CDCP2LA9L/p1766497887310029?thread_ts=1764869586.374709&cid=CDCP2LA9L and write the details of the testing in a comment I would also like to ask if upgrades was verified? If so please add a comment on how dualstack kubevirt platform upgrades was tested and passed and I can add the risk-assessed label for backporting. |
Contributor
|
Verified on an OCP release image built from this PR - registry.build06.ci.openshift.org/ci-ln-rs095h2/release:latest The HCP cluster has been created with: Hosted Cluster CR:`oc get co` from the hosted cluster:/verified by @orenc1 |
openshift-ci-robot
added
the
verified
Contributor
|
@orenc1: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
/retest |
Contributor
|
upgrade testing was done from 4.20 to 4.21 here: #2860 (comment) |
Contributor
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
anuragthehatter,
asood-rh,
barbora137,
eurijon,
huiran0826,
imatza-rh,
jechen0648 and
Meina-rh
Contributor
Contributor
|
/test okd-scos-images |
3 similar comments
Contributor
|
/test okd-scos-images |
Contributor
|
/test okd-scos-images |
Contributor
|
/test okd-scos-images |
Contributor
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2849
/assign orenc1