[release-4.20] OCPBUGS-66253: Add kubevirt platform to dual-stack supported platforms #2860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kubevirt platform in Hosted Control Planes (HCP) supports a dual-stack topology. Adding it to the dualStackPlatforms list to avoid reconciler error when the hosted cluster is dual-stack. Signed-off-by: Oren Cohen <ocohen@redhat.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
orenc1
changed the title
openshift-ci-robot
added
jira/severity-important
Contributor
|
@orenc1: This pull request references Jira Issue OCPBUGS-66253, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/jira refresh |
Contributor
|
@orenc1: This pull request references Jira Issue OCPBUGS-66253, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
Verified on an OCP 4.20 release image built from this PR - registry.build06.ci.openshift.org/ci-ln-c3ifyb2/release:latest Hosted Cluster CR:hosted cluster's cluster operators:ClusterVersion: NodePool - all nodes are up: Then I've upgraded this HostedCluster to 4.21 using the release image from #2861 by updating the HostedCluster's After several minutes, the HCP pods have been replaced with 4.21. Cluster Operators: ClusterVersion: The nodepool's nodes have also been upgraded, new VMs were created with RHCOS 4.21. /verified by @orenc1 |
openshift-ci-robot
added
the
verified
Contributor
|
@orenc1: This PR has been marked as verified by DetailsIn response to this:
Then I've upgraded this HostedCluster to 4.21 using the release image from #2861 by updating the HostedCluster's After several minutes, the HCP pods have been replaced with 4.21. Cluster Operators: ClusterVersion: The nodepool's nodes have also been upgraded, new VMs were created with RHCOS 4.21. /verified by @orenc1 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
anuragthehatter,
asood-rh,
barbora137,
eurijon,
huiran0826,
imatza-rh and
jechen0648
Contributor
|
@orenc1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade |
orenc1
changed the title
Contributor
Author
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
Contributor
|
@orenc1: This pull request references Jira Issue OCPBUGS-66253, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (lgao@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
openshift-merge-bot
bot
merged commit dbd9826
into
openshift:release-4.20
27 of 28 checks passed
Contributor
|
@orenc1: Jira Issue Verification Checks: Jira Issue OCPBUGS-66253 Jira Issue OCPBUGS-66253 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
This fix is also needed at 4.19.z |
|
@orenc1: new pull request created: #2864 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kubevirt platform in Hosted Control Planes (HCP) supports a dual-stack topology. Adding it to the dualStackPlatforms list to avoid reconciler error when the hosted cluster is dual-stack.
backport of #2849