[release-4.19] OCPBUGS-55798: Sync OpenStack CA Bundles from legacy location #866

stephenfin · 2025-05-30T11:06:41Z

This is a manual backport of #850 that also includes #860. It replaces #856.

Where fmt.Errorf is called with a single string parameter, it is faster and arguably more correct to call errors.New instead. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

There's some rework needed around CCM and the docs to get users to start using the new location of the CA cert. That is not going to happen in 4.19, so for now we opt to simply sync from the old place to the new place and leave the existing docs in place. In a future release, we can fully remove the old place (with a release note) and remove this syncer. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Reflect their respective namespaces. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

…config CM Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Unlike the other clients, this one does not use caching (which requires the operator have cluster-wide access to config maps). This is the same thing done for AWS. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

openshift-ci-robot · 2025-05-30T11:06:47Z

@stephenfin: This pull request references Jira Issue OCPBUGS-55798, which is invalid:

expected dependent Jira Issue OCPBUGS-55777 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual backport of #850 that also includes #860. It replaces #856.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2025-05-30T14:11:12Z

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.14%. Comparing base (9c3346a) to head (d5af20b).
Report is 13 commits behind head on release-4.19.

Files with missing lines	Patch %	Lines
...g/operator/secretannotator/openstack/reconciler.go	50.00%	5 Missing and 2 partials ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.19     #866      +/-   ##
================================================
+ Coverage         47.05%   47.14%   +0.08%     
================================================
  Files                97       97              
  Lines             11880    12011     +131     
================================================
+ Hits               5590     5662      +72     
- Misses             5676     5727      +51     
- Partials            614      622       +8

Files with missing lines	Coverage Δ
...g/operator/secretannotator/openstack/reconciler.go	`53.62% <50.00%> (-1.50%)`	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jianping-shu · 2025-06-06T07:55:34Z

pre-merge-tested with OCP-82011.
The regression test for aws mint cluster passed too.

jstuever

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2025-06-06T18:27:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jstuever · 2025-06-06T18:27:19Z

/jira refresh

openshift-ci-robot · 2025-06-06T18:27:26Z

@jstuever: This pull request references Jira Issue OCPBUGS-55798, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-55777 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-55777 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianping-shu · 2025-06-09T01:49:16Z

/label cherry-pick-approved

openshift-ci · 2025-06-09T04:21:40Z

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-06-09T04:24:35Z

@stephenfin: Jira Issue OCPBUGS-55798: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#866

Jira Issue OCPBUGS-55798 has been moved to the MODIFIED state.

Details

In response to this:

This is a manual backport of #850 that also includes #860. It replaces #856.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-06-09T06:14:00Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator
This PR has been included in build ose-cloud-credential-operator-container-v4.19.0-202506090516.p0.g675dad5.assembly.stream.el9.
All builds following this will include this PR.

stephenfin added 5 commits May 6, 2025 21:56

trivial: Use errors.New rather than fmt.Errorf

82f693a

Where fmt.Errorf is called with a single string parameter, it is faster and arguably more correct to call errors.New instead. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

manifests: Rename existing Role, RoleBinding manifests

d90783d

Reflect their respective namespaces. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

manifests: Add Role, RoleBinding for openshift-config/cloud-provider-…

633534a

…config CM Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

openstack: Use a "live client" for fetching config map

d5af20b

Unlike the other clients, this one does not use caching (which requires the operator have cluster-wide access to config maps). This is the same thing done for AWS. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 30, 2025

openshift-ci bot requested review from 2uasimojo and jstuever May 30, 2025 11:07

stephenfin mentioned this pull request May 30, 2025

[release-4.19] OCPBUGS-55798: Sync OpenStack CA Bundles from legacy location #856

Closed

jstuever self-assigned this Jun 5, 2025

jstuever approved these changes Jun 6, 2025

View reviewed changes

openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Jun 6, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2025

openshift-ci bot requested a review from jianping-shu June 6, 2025 18:27

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 9, 2025

openshift-merge-bot bot merged commit 675dad5 into openshift:release-4.19 Jun 9, 2025
13 checks passed

openshift-merge-bot bot deleted the cherry-pick-850-to-release-4.19 branch June 9, 2025 04:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release-4.19] OCPBUGS-55798: Sync OpenStack CA Bundles from legacy location #866

[release-4.19] OCPBUGS-55798: Sync OpenStack CA Bundles from legacy location #866

Uh oh!

stephenfin commented May 30, 2025

Uh oh!

openshift-ci-robot commented May 30, 2025

Uh oh!

codecov bot commented May 30, 2025 •

edited

Loading

Uh oh!

jianping-shu commented Jun 6, 2025

Uh oh!

jstuever left a comment

Uh oh!

openshift-ci bot commented Jun 6, 2025

Uh oh!

jstuever commented Jun 6, 2025

Uh oh!

openshift-ci-robot commented Jun 6, 2025

Uh oh!

jianping-shu commented Jun 9, 2025

Uh oh!

openshift-ci bot commented Jun 9, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 9, 2025

Uh oh!

openshift-bot commented Jun 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[release-4.19] OCPBUGS-55798: Sync OpenStack CA Bundles from legacy location #866

[release-4.19] OCPBUGS-55798: Sync OpenStack CA Bundles from legacy location #866

Uh oh!

Conversation

stephenfin commented May 30, 2025

Uh oh!

openshift-ci-robot commented May 30, 2025

Uh oh!

codecov bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jianping-shu commented Jun 6, 2025

Uh oh!

jstuever left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jun 6, 2025

Uh oh!

jstuever commented Jun 6, 2025

Uh oh!

openshift-ci-robot commented Jun 6, 2025

Uh oh!

jianping-shu commented Jun 9, 2025

Uh oh!

openshift-ci bot commented Jun 9, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 9, 2025

Uh oh!

openshift-bot commented Jun 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented May 30, 2025 •

edited

Loading