[release-4.19] OCPBUGS-55798: Sync OpenStack CA Bundles from legacy location #856
Conversation
Where fmt.Errorf is called with a single string parameter, it is faster and arguably more correct to call errors.New instead. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
There's some rework needed around CCM and the docs to get users to start using the new location of the CA cert. That is not going to happen in 4.19, so for now we opt to simply sync from the old place to the new place and leave the existing docs in place. In a future release, we can fully remove the old place (with a release note) and remove this syncer. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-55777 has been cloned as Jira Issue OCPBUGS-55798. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-55798, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-4.19 #856 +/- ##
================================================
- Coverage 47.05% 47.04% -0.02%
================================================
Files 97 97
Lines 11880 11889 +9
================================================
+ Hits 5590 5593 +3
- Misses 5676 5680 +4
- Partials 614 616 +2
🚀 New features to boost your workflow:
|
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@stephenfin: This pull request references Jira Issue OCPBUGS-55798, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The |
|
/override ci/prow/security |
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
|
@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
|
@stephenfin: Can not set label cherry-pick-approved: Must be member in one of these teams: [] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @lwan-wanglin @jianping-shu @huangmingxia Looks like I need one of you folks to stick the cherry-pick-approved label on this? |
|
Proposed openshift/release#64985 so assignment happens automatically going forward. |
|
@stephenfin Pls. see my comments on OCPBUGS-55777, it encountered RBAC issue in verification. |
|
/label cherry-pick-approved |
|
@rlobillo: Can not set label cherry-pick-approved: Must be member in one of these teams: [] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thank you. I'll take a look. |
|
The
I have proposed a fix at #860. Assuming all is good, will include that PR in this backport. |
|
/close In favor of #866 since I can't modify the branch. |
|
/close |
|
@stephenfin: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
This is an automated cherry-pick of #850
/assign stephenfin