Skip to content

Conversation

@enp0s3
Copy link
Member

@enp0s3 enp0s3 commented Dec 18, 2024

Signed-off-by: Igor Bezukh ibezukh@redhat.com

Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from enp0s3. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

this file intedned for the ephemeral local cluster setup
therefore it doesn't impose any security breach by exposing it
in the repo.

Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
@Barakmor1
Copy link
Member

Hey, thanks for the great work, it looks great overall! Just a small comment: I think we can now remove hack/update-kubevirtc.sh.

@Barakmor1
Copy link
Member

Also we need to update this with the new path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants