Skip to content

manifests: prefer fallocate to allocate swap file #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Apr 10, 2025
Merged

manifests: prefer fallocate to allocate swap file #93

openshift-merge-bot merged 1 commit into from
Apr 10, 2025

Conversation

@dollierp
Copy link
Contributor

@dollierp dollierp commented Feb 13, 2025

Some figures:

> time sudo fallocate -l '31940M' /var/tmp/swapfile

real	0m0.022s
user	0m0.005s
sys	0m0.012s

> time sudo dd if=/dev/zero of=/var/tmp/swapfile count=31940 bs=1M
31940+0 records in
31940+0 records out
33491517440 bytes (33 GB, 31 GiB) copied, 98.5563 s, 340 MB/s

real	1m38.583s
user	0m0.023s
sys	0m18.622s

@dollierp
Copy link
Contributor Author

dollierp commented Apr 10, 2025

Hi @enp0s3,

Would you mind taking a look?

Thanks.

enp0s3
enp0s3 reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dollierp Hi, thanks a lot for the contribution!

@dollierp
manifests: prefer fallocate to allocate swap file
6a42524 
Some figures:

    > time sudo fallocate -l '31940M' /var/tmp/swapfile

    real	0m0.022s
    user	0m0.005s
    sys	0m0.012s

    > time sudo dd if=/dev/zero of=/var/tmp/swapfile count=31940 bs=1M
    31940+0 records in
    31940+0 records out
    33491517440 bytes (33 GB, 31 GiB) copied, 98.5563 s, 340 MB/s

    real	1m38.583s
    user	0m0.023s
    sys	0m18.622s

Signed-off-by: Denis Ollier <dollierp@redhat.com>
enp0s3
enp0s3 reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
@dollierp Thank you!

@openshift-ci
Copy link

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Apr 10, 2025
@enp0s3 enp0s3 enabled auto-merge April 10, 2025 10:50
@openshift-merge-bot openshift-merge-bot bot merged commit da5404d into openshift-virtualization:main Apr 10, 2025
2 checks passed
@dollierp dollierp deleted the fallocate branch April 10, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enp0s3 enp0s3 enp0s3 approved these changes

Assignees

@enp0s3 enp0s3

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dollierp @enp0s3