Skip to content

Also change managed dependency classifier to ehcache to avoid breaking multi module projects #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 6 commits into from
Jan 9, 2026
Merged

Also change managed dependency classifier to ehcache to avoid breaking multi module projects #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02b01ab
Add 'changedManagedDependency: true' to ChangeDependencyClassifier in…
dsgrieve Jan 8, 2026
3c2c0e9
fix unit test to use mavenProject
dsgrieve Jan 8, 2026
23ae3b3
Merge branch 'main' into david/ehcache-jarkarta-classifier
timtebeek Jan 9, 2026
8b57986
Move test into existing `EhcacheJavaxToJakartaTest`
timtebeek Jan 9, 2026
81ef568
Remove ignored second text block
timtebeek Jan 9, 2026
bdcca8f
Also add `changeManagedDependency: true` to other recipes
timtebeek Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/resources/META-INF/rewrite/jakarta-ee-10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,10 +509,12 @@ recipeList:
groupId: org.apache.shiro
artifactId: "*"
newClassifier: jakarta
changeManagedDependency: true
- org.openrewrite.gradle.ChangeDependencyClassifier:
groupId: org.apache.shiro
artifactId: "*"
newClassifier: jakarta
changeManagedDependency: true
- org.openrewrite.java.dependencies.UpgradeDependencyVersion:
groupId: org.apache.shiro
artifactId: "*"
Expand Down
2 changes: 2 additions & 0 deletions src/main/resources/META-INF/rewrite/jakarta-ee-9.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,10 +1087,12 @@ recipeList:
groupId: org.ehcache
artifactId: ehcache
newClassifier: jakarta
changeManagedDependency: true
- org.openrewrite.maven.ChangeDependencyClassifier:
groupId: org.ehcache
artifactId: ehcache-transactions
newClassifier: jakarta
changeManagedDependency: true

---
type: specs.openrewrite.org/v1beta/recipe
Expand Down
2 changes: 2 additions & 0 deletions src/main/resources/META-INF/rewrite/jakarta-faces-3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ recipeList:
groupId: org.primefaces
artifactId: primefaces
newClassifier: jakarta
changeManagedDependency: true
- org.openrewrite.java.dependencies.UpgradeDependencyVersion:
groupId: org.primefaces
artifactId: primefaces
Expand All @@ -396,6 +397,7 @@ recipeList:
groupId: org.primefaces.extensions
artifactId: primefaces-extensions
newClassifier: jakarta
changeManagedDependency: true
- org.openrewrite.java.dependencies.UpgradeDependencyVersion:
groupId: org.primefaces.extensions
artifactId: primefaces-extensions
Expand Down
2 changes: 2 additions & 0 deletions src/main/resources/META-INF/rewrite/jakarta-faces-4.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ recipeList:
groupId: org.primefaces
artifactId: primefaces
newClassifier: jakarta
changeManagedDependency: true
- org.openrewrite.java.dependencies.UpgradeDependencyVersion:
groupId: org.primefaces
artifactId: primefaces
Expand All @@ -283,6 +284,7 @@ recipeList:
groupId: org.primefaces.extensions
artifactId: primefaces-extensions
newClassifier: jakarta
changeManagedDependency: true
- org.openrewrite.java.dependencies.UpgradeDependencyVersion:
groupId: org.primefaces.extensions
artifactId: primefaces-extensions
Expand Down
81 changes: 75 additions & 6 deletions ...te/jakarta/EhcacheJavaxtoJakartaTest.java → ...te/jakarta/EhcacheJavaxToJakartaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,18 @@

import org.junit.jupiter.api.Test;
import org.openrewrite.DocumentExample;
import org.openrewrite.config.Environment;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;

import static org.assertj.core.api.Assertions.assertThat;
import static org.openrewrite.java.Assertions.mavenProject;
import static org.openrewrite.maven.Assertions.pomXml;

class EhcacheJavaxtoJakartaTest implements RewriteTest {
class EhcacheJavaxToJakartaTest implements RewriteTest {

@Override
public void defaults(RecipeSpec spec) {
spec.recipe(Environment.builder()
.scanRuntimeClasspath("org.openrewrite.java.migrate")
.build()
.activateRecipes("org.openrewrite.java.migrate.jakarta.EhcacheJavaxToJakarta"));
spec.recipeFromResources("org.openrewrite.java.migrate.jakarta.EhcacheJavaxToJakarta");
}

@DocumentExample
Expand Down Expand Up @@ -95,4 +92,76 @@ void migrateEhcacheDependencies() {
)
);
}

@Test
void multiModuleManagedDependencyClassifierChanged() {
rewriteRun(
mavenProject("parent",
pomXml(
"""
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>com.example</groupId>
<artifactId>parent</artifactId>
<version>1.2.3</version>
<packaging>pom</packaging>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.ehcache</groupId>
<artifactId>ehcache</artifactId>
<version>3.9.9</version>
</dependency>
</dependencies>
</dependencyManagement>
</project>
""",
spec -> spec.after(actual ->
assertThat(actual)
.containsPattern("<version>3\\.10\\.\\d+</version>")
.contains("<classifier>jakarta</classifier>")
.actual())
)
),
mavenProject("child",
pomXml(
"""
<project>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.example</groupId>
<artifactId>parent</artifactId>
<version>1.2.3</version>
</parent>
<artifactId>child</artifactId>
<dependencies>
<dependency>
<groupId>org.ehcache</groupId>
<artifactId>ehcache</artifactId>
</dependency>
</dependencies>
</project>
""",
"""
<project>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.example</groupId>
<artifactId>parent</artifactId>
<version>1.2.3</version>
</parent>
<artifactId>child</artifactId>
<dependencies>
<dependency>
<groupId>org.ehcache</groupId>
<artifactId>ehcache</artifactId>
<classifier>jakarta</classifier>
</dependency>
</dependencies>
</project>
"""
)
)
);
}
}