Also change managed dependency classifier to ehcache to avoid breaking multi module projects #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Ensure
<classifier>jakarta</classifier>is added to a managedehcachedependency in a parent pom.What's your motivation?
The
org.openrewrite.java.migrate.jakarta.EhcacheJavaxToJakartarecipe of jakarta-ee-9.yml adds ajakartaclassifier, but does not add the classifier to the managed dependency forehchachein the parent pom. The classifier needs to be added to both the parent's managed dependency and to the child dependency or a 'missing dependency version' error will happen on a maven build.Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist