Skip to content

Conversation

@dsgrieve
Copy link
Contributor

@dsgrieve dsgrieve commented Jan 8, 2026

What's changed?

Ensure <classifier>jakarta</classifier> is added to a managed ehcache dependency in a parent pom.

What's your motivation?

The org.openrewrite.java.migrate.jakarta.EhcacheJavaxToJakarta recipe of jakarta-ee-9.yml adds a jakarta classifier, but does not add the classifier to the managed dependency for ehchache in the parent pom. The classifier needs to be added to both the parent's managed dependency and to the child dependency or a 'missing dependency version' error will happen on a maven build.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Jan 8, 2026
@timtebeek timtebeek changed the title David/ehcache jarkarta classifier Also change managed dependency classifier to ehcache to avoid breaking multi module projects Jan 9, 2026
@timtebeek timtebeek added the bug Something isn't working label Jan 9, 2026
@timtebeek timtebeek merged commit 9b9e288 into main Jan 9, 2026
2 checks passed
@timtebeek timtebeek deleted the david/ehcache-jarkarta-classifier branch January 9, 2026 09:58
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants