Skip to content

8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058#265

Closed
rm-gh-8 wants to merge 3 commits intoopenjdk:masterfrom
rm-gh-8:JDK-8369335-V25
Closed

8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058#265
rm-gh-8 wants to merge 3 commits intoopenjdk:masterfrom
rm-gh-8:JDK-8369335-V25

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Feb 12, 2026

Backporting JDK-8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058.

This PR fixes two OpenGL tests (ScaleParamsOOB.java and OpaqueDest.java) fail after JDK-8358058 with color mismatch errors due to HiDPI fractional scaling issues when using OpenGL with hardware acceleration. Tests updated to handle Windows HiDPI fractional scaling correctly.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/sun/java2d/OpenGL/OpaqueDest.java
make test TEST=test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java

Note: test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java fails on linux-x64 and linux-aarch64 (using xvfb and libmesa software rendering) with a color mismatch error (expected=ffff0000 actual=ff000000 at x=40 y=40), similar to the error resolved in this PR, but remains unaddressed since to JDK-8358058. Created JDK-8377908 to capture the issue.

Results attached:

macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
windows-x64-specific-test.log
windows-x64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369335 needs maintainer approval

Issue

  • JDK-8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/265/head:pull/265
$ git checkout pull/265

Update a local copy of the PR:
$ git checkout pull/265
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 265

View PR using the GUI difftool:
$ git pr show -t 265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/265.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8 rm-gh-8 changed the base branch from master to pr/249 February 12, 2026 21:33
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Feb 12, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into pr/249 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 12, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369335: Two  sun/java2d/OpenGL tests fail on Windows after JDK-8358058

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport d6ca382f4ee5793dfa191bba694a7fef88c591fc 8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058 Feb 12, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 12, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 12, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review February 13, 2026 16:37
@openjdk openjdk Bot added the rfr Pull request is ready for review label Feb 13, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Feb 13, 2026

Webrevs

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Feb 13, 2026

/approval request for backport of JDK-8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058.

This test fix addresses issues introduced by JDK-8358058, which was added for Oracle JDK parity.

Note: test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java fails on linux-x64 and linux-aarch64 (using xvfb and libmesa software rendering) with a color mismatch error (expected=ffff0000 actual=ff000000 at x=40 y=40), similar to the error resolved in this PR, but remains unaddressed since to JDK-8358058. Created JDK-8377908 to capture the issue.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 13, 2026

@rm-gh-8
8369335: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Feb 13, 2026
@openjdk-notifier openjdk-notifier Bot changed the base branch from pr/249 to master February 16, 2026 19:58
@openjdk-notifier
Copy link
Copy Markdown

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8369335-V25
git fetch https://git.openjdk.org/jdk25u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk Bot removed the clean Identical backport; no merge resolution required label Feb 16, 2026
@openjdk openjdk Bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Feb 16, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Feb 20, 2026

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Feb 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 20, 2026

@rm-gh-8
Your change (at version 492a437) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 20, 2026

Going to push as commit 6a95907.
Since your change was applied there have been 6 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Feb 20, 2026
@openjdk openjdk Bot closed this Feb 20, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 20, 2026

@phohensee @rm-gh-8 Pushed as commit 6a95907.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants