Skip to content

8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently#249

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8358058-V25
Open

8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently#249
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8358058-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Feb 9, 2026

Backporting JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently.

This PR migrates tests from a closed repository with improvements including corrected thread logic, paint-on-demand behavior, and support for all systems (not just OpenGL).

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/sun/java2d/OpenGL/DrawBitmaskImage.java
make test TEST=test/jdk/sun/java2d/OpenGL/DrawBufImgOp.java
make test TEST=test/jdk/sun/java2d/OpenGL/DrawImageBg.java
make test TEST=test/jdk/sun/java2d/OpenGL/LargeOps.java
make test TEST=test/jdk/sun/java2d/OpenGL/OpaqueDest.java
make test TEST=test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java
make test TEST=test/jdk/sun/java2d/OpenGL/ShapeClip.java
make test TEST=test/jdk/sun/java2d/OpenGL/SrcMaskOps.java
make test TEST=test/jdk/sun/java2d/OpenGL/VolatileSubRegion.java
make test TEST=test/jdk/sun/java2d/OpenGL/XformVolatile.java

Note: test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java fails on linux-x64 and linux-aarch64 (using libmesa software rendering) with a color mismatch error (expected=ffff0000 actual=ff000000 at x=40 y=40), similar to JDK-8369335. The similar error on Windows (not observed during my testing) will be fixed for in a separate backport PR (#265), but not the issue mentioned. Created JDK-8377908 to capture the issue.

Results attached:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
windows-x64-specific-3-test.log
windows-x64-specific-4-test.log
windows-x64-specific-5-test.log
windows-x64-specific-6-test.log
windows-x64-specific-7-test.log
windows-x64-specific-8-test.log
windows-x64-specific-9-test.log
windows-x64-specific-10-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
macos-aarch64-specific-3-test.log
macos-aarch64-specific-4-test.log
macos-aarch64-specific-5-test.log
macos-aarch64-specific-6-test.log
macos-aarch64-specific-7-test.log
macos-aarch64-specific-8-test.log
macos-aarch64-specific-9-test.log
macos-aarch64-specific-10-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-x64-specific-3-test.log
linux-x64-specific-4-test.log
linux-x64-specific-5-test.log
linux-x64-specific-6-test.log
linux-x64-specific-7-test.log
linux-x64-specific-8-test.log
linux-x64-specific-9-test.log
linux-x64-specific-10-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-aarch64-specific-3-test.log
linux-aarch64-specific-4-test.log
linux-aarch64-specific-5-test.log
linux-aarch64-specific-6-test.log
linux-aarch64-specific-7-test.log
linux-aarch64-specific-8-test.log
linux-aarch64-specific-9-test.log
linux-aarch64-specific-10-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358058 needs maintainer approval

Issue

  • JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/249/head:pull/249
$ git checkout pull/249

Update a local copy of the PR:
$ git checkout pull/249
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 249

View PR using the GUI difftool:
$ git pr show -t 249

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/249.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 9, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ebeb77baaeb6d9098d7462f5ddf61d8583b1e493 8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently Feb 9, 2026
@openjdk
Copy link

openjdk bot commented Feb 9, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 9, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review February 12, 2026 20:38
@openjdk
Copy link

openjdk bot commented Feb 12, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2026

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Feb 13, 2026

/approval request for backport of JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently.

This is a test fix.

For parity with Oracle JDK.

Note: test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java fails on linux-x64 and linux-aarch64 (with libmesa software rendering) due to a color mismatch (expected=ffff0000 actual=ff000000 at x=40 y=40), similar to JDK-8369335. A separate backport PR (#265) addresses the Windows variant of this issue, but not the Linux failure mentioned here. Created JDK-8377908 to capture the issue.

@openjdk
Copy link

openjdk bot commented Feb 13, 2026

@rm-gh-8
8358058: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant