8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently#249
8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently#249rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently. This is a test fix. For parity with Oracle JDK. Note: test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java fails on linux-x64 and linux-aarch64 (with libmesa software rendering) due to a color mismatch (expected=ffff0000 actual=ff000000 at x=40 y=40), similar to JDK-8369335. A separate backport PR (#265) addresses the Windows variant of this issue, but not the Linux failure mentioned here. Created JDK-8377908 to capture the issue. |
Backporting JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently.
This PR migrates tests from a closed repository with improvements including corrected thread logic, paint-on-demand behavior, and support for all systems (not just OpenGL).
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/sun/java2d/OpenGL/DrawBitmaskImage.java
make test TEST=test/jdk/sun/java2d/OpenGL/DrawBufImgOp.java
make test TEST=test/jdk/sun/java2d/OpenGL/DrawImageBg.java
make test TEST=test/jdk/sun/java2d/OpenGL/LargeOps.java
make test TEST=test/jdk/sun/java2d/OpenGL/OpaqueDest.java
make test TEST=test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java
make test TEST=test/jdk/sun/java2d/OpenGL/ShapeClip.java
make test TEST=test/jdk/sun/java2d/OpenGL/SrcMaskOps.java
make test TEST=test/jdk/sun/java2d/OpenGL/VolatileSubRegion.java
make test TEST=test/jdk/sun/java2d/OpenGL/XformVolatile.java
Note: test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java fails on linux-x64 and linux-aarch64 (using libmesa software rendering) with a color mismatch error (expected=ffff0000 actual=ff000000 at x=40 y=40), similar to JDK-8369335. The similar error on Windows (not observed during my testing) will be fixed for in a separate backport PR (#265), but not the issue mentioned. Created JDK-8377908 to capture the issue.
Results attached:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
windows-x64-specific-3-test.log
windows-x64-specific-4-test.log
windows-x64-specific-5-test.log
windows-x64-specific-6-test.log
windows-x64-specific-7-test.log
windows-x64-specific-8-test.log
windows-x64-specific-9-test.log
windows-x64-specific-10-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
macos-aarch64-specific-3-test.log
macos-aarch64-specific-4-test.log
macos-aarch64-specific-5-test.log
macos-aarch64-specific-6-test.log
macos-aarch64-specific-7-test.log
macos-aarch64-specific-8-test.log
macos-aarch64-specific-9-test.log
macos-aarch64-specific-10-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-x64-specific-3-test.log
linux-x64-specific-4-test.log
linux-x64-specific-5-test.log
linux-x64-specific-6-test.log
linux-x64-specific-7-test.log
linux-x64-specific-8-test.log
linux-x64-specific-9-test.log
linux-x64-specific-10-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-aarch64-specific-3-test.log
linux-aarch64-specific-4-test.log
linux-aarch64-specific-5-test.log
linux-aarch64-specific-6-test.log
linux-aarch64-specific-7-test.log
linux-aarch64-specific-8-test.log
linux-aarch64-specific-9-test.log
linux-aarch64-specific-10-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/249/head:pull/249$ git checkout pull/249Update a local copy of the PR:
$ git checkout pull/249$ git pull https://git.openjdk.org/jdk25u-dev.git pull/249/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 249View PR using the GUI difftool:
$ git pr show -t 249Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/249.diff
Using Webrev
Link to Webrev Comment