Skip to content

feat: handle UI_InsertFile postMessage from Collabora#2270

Merged
JammingBen merged 1 commit intoopencloud-eu:mainfrom
pedropintosilva:feat/handle-ui-insert-file
Apr 7, 2026
Merged

feat: handle UI_InsertFile postMessage from Collabora#2270
JammingBen merged 1 commit intoopencloud-eu:mainfrom
pedropintosilva:feat/handle-ui-insert-file

Conversation

@pedropintosilva
Copy link
Copy Markdown
Contributor

Add handler for Collabora's UI_InsertFile postMessage, which is sent
when EnableInsertRemoteFile is true. Opens the OpenCloud file picker
filtered by MIME types from the message, then sends back the selected
file's download URL via the callback specified by
Collabora (Action_CompareDocuments).

Note: line 364, added the return after the UI_InsertGraphic handler for
consistency with the other handlers.

Signed-off-by: Pedro Pinto Silva pedro.silva@collabora.com

opencloud-compare-documents

@pedropintosilva
Copy link
Copy Markdown
Contributor Author

server-side: opencloud-eu/opencloud#2555

Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and works just fine, thanks!

Though I had to bump the Collabora version in our dev setup to v25.04.9.4.1 to make it work. I guess this feature is not available in older versions? If so, do you mind bumping the Collabora version in our docker-compose.yml file also with this?

@pedropintosilva
Copy link
Copy Markdown
Contributor Author

Code LGTM and works just fine, thanks!

Thanks!

Though I had to bump the Collabora version in our dev setup to v25.04.9.4.1 to make it work. I guess this feature is not available in older versions? If so, do you mind bumping the Collabora version in our docker-compose.yml file also with this?

Ah good catch!

My setup uses Collabora Online build from sources but you are right: Action_CompareDocuments is New in version 25.04.9.1.

will update the PR

Add handler for Collabora's UI_InsertFile postMessage, which is sent
when EnableInsertRemoteFile is true. Opens the OpenCloud file picker
filtered by MIME types from the message, then sends back the selected
file's download URL via the callback specified by
Collabora (Action_CompareDocuments).

Note: line 364, added the return after the UI_InsertGraphic handler for
consistency with the other handlers.

Bumped Collabora version in docker-compose.yml as Action_CompareDocuments
was introduced only in version 25.04.9.1:

https://sdk.collaboraonline.com/docs/postmessage_api.html

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
@pedropintosilva pedropintosilva force-pushed the feat/handle-ui-insert-file branch from cb2b277 to 10e98fe Compare April 7, 2026 08:01
Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JammingBen JammingBen merged commit 77fc451 into opencloud-eu:main Apr 7, 2026
28 checks passed
@openclouders openclouders mentioned this pull request Apr 7, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants