feat: enable EnableInsertRemoteFile WOPI flag for Collabora#2555
Open
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
Open
feat: enable EnableInsertRemoteFile WOPI flag for Collabora#2555pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
Set EnableInsertRemoteFile: true in CheckFileInfo response so Collabora shows "Insert Multimedia" and "Compare Document" menu entries. This triggers UI_InsertFile postMessages to the WOPI host, following the same pattern as the existing EnableInsertRemoteImage flag. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
|
Author
|
client-side: opencloud-eu/web#2270 |
Author
|
I cannot see what are the specific complains from SonarCloud , I'm not part of the org so, I get some error when attempting to open it in my SonarCloud account. |
JammingBen
approved these changes
Apr 2, 2026
Member
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
LGTM and works fine from my point of view.
IMO the SonarCloud error can be neglected in this case. @rhafer how do you handle these kind of things at the moment?
Author
|
Thanks @JammingBen! It seems the workflows will not run until some sort of approval:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set EnableInsertRemoteFile: true in CheckFileInfo response so Collabora
shows "Insert Multimedia" and "Compare Document" menu entries. This
triggers UI_InsertFile postMessages to the WOPI host, following the same
pattern as the existing EnableInsertRemoteImage flag.
Signed-off-by: Pedro Pinto Silva pedro.silva@collabora.com
Screenshots (if appropriate):