Skip to content

Normalize module client base_url trailing slash #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LittleChenLiya wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

Normalize module client base_url trailing slash #2990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/openai/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def webhook_secret(self, value: str | None) -> None: # type: ignore
@override
def base_url(self) -> _httpx.URL:
if base_url is not None:
return _httpx.URL(base_url)
return self._enforce_trailing_slash(_httpx.URL(base_url))

return super().base_url

Expand Down
11 changes: 9 additions & 2 deletions tests/test_module_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,15 @@ def test_base_url_option() -> None:

openai.base_url = "http://foo.com"

assert openai.base_url == URL("http://foo.com")
assert openai.completions._client.base_url == URL("http://foo.com")
assert openai.base_url == "http://foo.com"
assert openai.completions._client.base_url.raw_path == b"/"


def test_base_url_option_without_trailing_slash() -> None:
openai.base_url = "http://foo.com/custom/path"

assert openai.base_url == "http://foo.com/custom/path"
assert openai.completions._client.base_url == URL("http://foo.com/custom/path/")


def test_timeout_option() -> None:
Expand Down