Normalize module client base_url trailing slash#2990
Open
LittleChenLiya wants to merge 1 commit intoopenai:mainfrom
Open
Normalize module client base_url trailing slash#2990LittleChenLiya wants to merge 1 commit intoopenai:mainfrom
LittleChenLiya wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix inconsistent
base_urlnormalization between the module-level client and instantiated clients.When
openai.base_urlis set without a trailing slash,_ModuleClient.base_urlreturned the raw URL, whileOpenAI(base_url=...)normalized it with a trailing slash. This could lead to malformed request URLs in module-level usage.Changes
_ModuleClient.base_urlusing the same trailing-slash enforcement as instantiated clientsbase_urlwith a custom path and no trailing slashopenai.base_urlvalue unchanged as user input, while ensuring the resolved client URL is normalizedTesting
python -m pytest tests/test_module_client.py -n 0python -m pytest tests/test_client.py -k "base_url" -n 0Closes #1373