Skip to content

fix update config 100 #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Nov 4, 2025
Merged

fix update config 100 #2902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/helpermodules/update_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2606,8 +2606,10 @@ def upgrade_datastore_99(self) -> None:
def upgrade_datastore_100(self) -> None:
def upgrade(topic: str, payload) -> Optional[dict]:
if "openWB/general/chargemode_config/retry_failed_phase_switches" == topic:
return {"openWB/general/chargemode_config/pv_charging/retry_failed_phase_switches": payload}
return {"openWB/general/chargemode_config/pv_charging/retry_failed_phase_switches":
decode_payload(payload)}
if "openWB/general/chargemode_config/phase_switch_delay" == topic:
return {"openWB/general/chargemode_config/pv_charging/phase_switch_delay": payload}
return {"openWB/general/chargemode_config/pv_charging/phase_switch_delay":
decode_payload(payload)}
Comment on lines 2607 to +2613
Copy link
Contributor

@tpd-opitz tpd-opitz Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist sicher gestellt, dass nur diese 2 Topics übergeben werden?

Suggested change
def upgrade(topic: str, payload) -> Optional[dict]:
if "openWB/general/chargemode_config/retry_failed_phase_switches" == topic:
return {"openWB/general/chargemode_config/pv_charging/retry_failed_phase_switches": payload}
return {"openWB/general/chargemode_config/pv_charging/retry_failed_phase_switches":
decode_payload(payload)}
if "openWB/general/chargemode_config/phase_switch_delay" == topic:
return {"openWB/general/chargemode_config/pv_charging/phase_switch_delay": payload}
return {"openWB/general/chargemode_config/pv_charging/phase_switch_delay":
decode_payload(payload)}
def upgrade(topic: str, payload) -> Optional[dict]:
return {f"openWB/general/chargemode_config/pv_charging/{topic.rsplit("/", maxsplit=1)[-1]}":
decode_payload(payload)}

Copy link
Contributor Author

@LKuemmel LKuemmel Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es sollen ausschließlich diese 2 Topics verschoben werden.

self._loop_all_received_topics(upgrade)
self.__update_topic("openWB/system/datastore_version", 101)