fix update config 100 #2902
Merged
fix update config 100 #2902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpd-opitz
reviewed
Nov 4, 2025
Comment on lines
2607
to
+2613
| def upgrade(topic: str, payload) -> Optional[dict]: | ||
| if "openWB/general/chargemode_config/retry_failed_phase_switches" == topic: | ||
| return {"openWB/general/chargemode_config/pv_charging/retry_failed_phase_switches": payload} | ||
| return {"openWB/general/chargemode_config/pv_charging/retry_failed_phase_switches": | ||
| decode_payload(payload)} | ||
| if "openWB/general/chargemode_config/phase_switch_delay" == topic: | ||
| return {"openWB/general/chargemode_config/pv_charging/phase_switch_delay": payload} | ||
| return {"openWB/general/chargemode_config/pv_charging/phase_switch_delay": | ||
| decode_payload(payload)} |
Contributor
There was a problem hiding this comment.
Ist sicher gestellt, dass nur diese 2 Topics übergeben werden?
Suggested change
| def upgrade(topic: str, payload) -> Optional[dict]: | |
| if "openWB/general/chargemode_config/retry_failed_phase_switches" == topic: | |
| return {"openWB/general/chargemode_config/pv_charging/retry_failed_phase_switches": payload} | |
| return {"openWB/general/chargemode_config/pv_charging/retry_failed_phase_switches": | |
| decode_payload(payload)} | |
| if "openWB/general/chargemode_config/phase_switch_delay" == topic: | |
| return {"openWB/general/chargemode_config/pv_charging/phase_switch_delay": payload} | |
| return {"openWB/general/chargemode_config/pv_charging/phase_switch_delay": | |
| decode_payload(payload)} | |
| def upgrade(topic: str, payload) -> Optional[dict]: | |
| return {f"openWB/general/chargemode_config/pv_charging/{topic.rsplit("/", maxsplit=1)[-1]}": | |
| decode_payload(payload)} |
Contributor
Author
There was a problem hiding this comment.
Es sollen ausschließlich diese 2 Topics verschoben werden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.