Skip to content

Prepare release of 0.35 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
okurz wants to merge 1 commit into from
Closed

Prepare release of 0.35 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,26 @@
Revision history for Perl extension Mojo-IOLoop-ReadWriteProcess

{{$NEXT}}
0.35 2025-03-17 12:20:20Z
Copy link
Collaborator

@perlpunk perlpunk Mar 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a modern version here?

Suggested change
0.35 2025-03-17 12:20:20Z
v0.350.0 2025-03-17 12:20:20Z

https://github.com/perlpunk/perl5-module-meta links to
https://blogs.perl.org/users/grinnz/2018/04/a-guide-to-versions-in-perl.html

Copy link
Member Author

@okurz okurz Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you meant 0.35.0 instead of 0.350? If I understand https://semver.org/#is-v123-a-semantic-version and https://github.com/perlpunk/perl5-module-meta correctly then our new version should be "0.35.0" without the "v" prefix but in the Changes file maybe we should use v? Also based on https://build.opensuse.org/projects/devel:languages:perl/packages/perl-Perl-Tidy/files/perl-Perl-Tidy.spec?expand=1 or other recent package updates in https://build.opensuse.org/project/show/devel:languages:perl and https://github.com/search?q=repo%3Amojolicious%2Fmojo%209.40&type=code the git tag should be "v0.35.0" but the string in Changes and in source should be w/o the "v" prefix. Right?

Also I am considering 1.0.0 to make the switch of version format more apparent

Copy link
Collaborator

@perlpunk perlpunk Mar 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we should use v0.350.0.
v0.35.0 would be lower than 0.35, beause 0.35 is the same as 0.350 and the same as v0.350.0

The git tag is completely irrelevant to CPAN.

I'm not sure what you mean by linking to https://build.opensuse.org/projects/devel:languages:perl/packages/perl-Perl-Tidy/files/perl-Perl-Tidy.spec?expand=1
That's what cpanspec makes of the version from CPAN. It removes the v from the beginning for rpm.

So: please use the v everywhere and two dots.

Copy link
Collaborator

@perlpunk perlpunk Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://metacpan.org/dist/YAML-PP
Tarball name: YAML-PP-v0.39.0.tar.gz

https://metacpan.org/release/TINITA/YAML-PP-v0.39.0/source/META.json#L214

"version" : "v0.39.0",

https://metacpan.org/release/TINITA/YAML-PP-v0.39.0/source/META.yml

version: v0.39.0

https://metacpan.org/release/TINITA/YAML-PP-v0.39.0/source/Changes#L3

v0.39.0 2025-02-10 00:01:45+01:00

https://metacpan.org/dist/YAML-PP/source/lib/YAML/PP.pm#L6

our $VERSION = 'v0.39.0'; # VERSION

Copy link
Collaborator

@perlpunk perlpunk Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and https://blogs.perl.org/users/grinnz/2018/04/a-guide-to-versions-in-perl.html

For this reason it's best to include both a leading "v" and at least two decimal separators for clarity when using tuple versions.

Copy link
Collaborator

@perlpunk perlpunk Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And linking to https://github.com/search?q=repo%3Amojolicious%2Fmojo%209.40&type=code is irrelevant, because Mojolicious still uses the decimal version format.

Copy link
Member Author

@okurz okurz Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it says "when using tuple versions" but I wouldn't use tuple versions but decimal version format. Again, I would avoid the ambiguity about 0.35X by using 1.0.0

Copy link
Member Author

@okurz okurz Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> #74

Copy link
Collaborator

@perlpunk perlpunk Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it says "when using tuple versions" but I wouldn't use tuple versions but decimal version format. Again, I would avoid the ambiguity about 0.35X by using 1.0.0

1.0.0 is a tupled version. and my suggestion was to use the tupled version format from now on.

- Fix sporadic failures in `t/01_run.t`
- Debug test for stopping whole process group
- Fix race condition in `is_running` when `kill_whole_group` is set
- Apply tidy 20250105
- Fix handling process groups when initial process is not running anymore
- Use the correct formatter
- Fix errors on Build.PL
- Remove workaround for missing dependency on TAP::Harness::GithubActions
- Update to codecov@v3
- Add Minilla to the ci target
- Update minil.toml to have the harness arguments enabled
- Use github formatter for prove
- Fix tests and rename workflow
- Use reduced test matrix on MacOSX
- Test on OSX and Linux with a reduced perl matrix
- t: Add another check for /bin/true
- Fix tidy also for OSX
- Mention syntactic sugar to help when debugging
- Enable support for MacOSX (darwin)

0.34 2023-09-18T15:47:18Z
- Adapt to deprecation of spurt in upstream Mojolicious
Expand Down
2 changes: 1 addition & 1 deletion META.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"web" : "https://github.com/openSUSE/Mojo-IOLoop-ReadWriteProcess"
}
},
"version" : "0.34",
"version" : "0.35",
"x_contributors" : [
"Adam Williamson <awilliam@redhat.com>",
"Clemens Famulla-Conrad <cfamullaconrad@suse.de>",
Expand Down
2 changes: 1 addition & 1 deletion lib/Mojo/IOLoop/ReadWriteProcess.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package Mojo::IOLoop::ReadWriteProcess;

our $VERSION = '0.34';
our $VERSION = '0.35';

use Mojo::Base 'Mojo::EventEmitter';
use Mojo::File 'path';
Expand Down
Loading