Skip to content

Conversation

@okurz
Copy link
Member

@okurz okurz commented Mar 17, 2025

No description provided.

@kalikiana
Copy link
Member

    not ok 2 - sigchld_handler.pl exit with 0
    
    #   Failed test 'sigchld_handler.pl exit with 0'
    #   at t/01_run.t line 649.
    #          got: '255'
    #     expected: '0'
    not ok 3 - SIG_CHLD handler was executed
    
    #   Failed test 'SIG_CHLD handler was executed'
    #   at t/01_run.t line 651.
    #                   ''
    #     doesn't match '(?^:SIG_CHLD)'
    1..3
    # Looks like you failed 2 tests of 3.
not ok 12 - SIG_CHLD handler in spawned process

#   Failed test 'SIG_CHLD handler in spawned process'
#   at t/01_run.t line 652.

Same as on master. Just for reference since I was checking if there was any new errors.

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (662e615) to head (d6396b4).
Report is 4 commits behind head on master.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   89.36%   89.25%   -0.12%     
==========================================
  Files          27       27              
  Lines         903      903              
  Branches      207      207              
==========================================
- Hits          807      806       -1     
  Misses         21       21              
- Partials       75       76       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Revision history for Perl extension Mojo-IOLoop-ReadWriteProcess

{{$NEXT}}
0.35 2025-03-17 12:20:20Z
Copy link
Collaborator

@perlpunk perlpunk Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a modern version here?

Suggested change
0.35 2025-03-17 12:20:20Z
v0.350.0 2025-03-17 12:20:20Z

https://github.com/perlpunk/perl5-module-meta links to
https://blogs.perl.org/users/grinnz/2018/04/a-guide-to-versions-in-perl.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you meant 0.35.0 instead of 0.350? If I understand https://semver.org/#is-v123-a-semantic-version and https://github.com/perlpunk/perl5-module-meta correctly then our new version should be "0.35.0" without the "v" prefix but in the Changes file maybe we should use v? Also based on https://build.opensuse.org/projects/devel:languages:perl/packages/perl-Perl-Tidy/files/perl-Perl-Tidy.spec?expand=1 or other recent package updates in https://build.opensuse.org/project/show/devel:languages:perl and https://github.com/search?q=repo%3Amojolicious%2Fmojo%209.40&type=code the git tag should be "v0.35.0" but the string in Changes and in source should be w/o the "v" prefix. Right?

Also I am considering 1.0.0 to make the switch of version format more apparent

Copy link
Collaborator

@perlpunk perlpunk Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we should use v0.350.0.
v0.35.0 would be lower than 0.35, beause 0.35 is the same as 0.350 and the same as v0.350.0

The git tag is completely irrelevant to CPAN.

I'm not sure what you mean by linking to https://build.opensuse.org/projects/devel:languages:perl/packages/perl-Perl-Tidy/files/perl-Perl-Tidy.spec?expand=1
That's what cpanspec makes of the version from CPAN. It removes the v from the beginning for rpm.

So: please use the v everywhere and two dots.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and https://blogs.perl.org/users/grinnz/2018/04/a-guide-to-versions-in-perl.html

For this reason it's best to include both a leading "v" and at least two decimal separators for clarity when using tuple versions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And linking to https://github.com/search?q=repo%3Amojolicious%2Fmojo%209.40&type=code is irrelevant, because Mojolicious still uses the decimal version format.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it says "when using tuple versions" but I wouldn't use tuple versions but decimal version format. Again, I would avoid the ambiguity about 0.35X by using 1.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> #74

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it says "when using tuple versions" but I wouldn't use tuple versions but decimal version format. Again, I would avoid the ambiguity about 0.35X by using 1.0.0

1.0.0 is a tupled version. and my suggestion was to use the tupled version format from now on.

@okurz
Copy link
Member Author

okurz commented Apr 2, 2025

was replaced by #74

@okurz okurz closed this Apr 2, 2025
@okurz okurz deleted the fix/spew branch April 2, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants