-
Notifications
You must be signed in to change notification settings - Fork 15
Prepare release of 0.35 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Same as on master. Just for reference since I was checking if there was any new errors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 89.36% 89.25% -0.12%
==========================================
Files 27 27
Lines 903 903
Branches 207 207
==========================================
- Hits 807 806 -1
Misses 21 21
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Revision history for Perl extension Mojo-IOLoop-ReadWriteProcess | ||
|
|
||
| {{$NEXT}} | ||
| 0.35 2025-03-17 12:20:20Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a modern version here?
| 0.35 2025-03-17 12:20:20Z | |
| v0.350.0 2025-03-17 12:20:20Z |
https://github.com/perlpunk/perl5-module-meta links to
https://blogs.perl.org/users/grinnz/2018/04/a-guide-to-versions-in-perl.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you meant 0.35.0 instead of 0.350? If I understand https://semver.org/#is-v123-a-semantic-version and https://github.com/perlpunk/perl5-module-meta correctly then our new version should be "0.35.0" without the "v" prefix but in the Changes file maybe we should use v? Also based on https://build.opensuse.org/projects/devel:languages:perl/packages/perl-Perl-Tidy/files/perl-Perl-Tidy.spec?expand=1 or other recent package updates in https://build.opensuse.org/project/show/devel:languages:perl and https://github.com/search?q=repo%3Amojolicious%2Fmojo%209.40&type=code the git tag should be "v0.35.0" but the string in Changes and in source should be w/o the "v" prefix. Right?
Also I am considering 1.0.0 to make the switch of version format more apparent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we should use v0.350.0.
v0.35.0 would be lower than 0.35, beause 0.35 is the same as 0.350 and the same as v0.350.0
The git tag is completely irrelevant to CPAN.
I'm not sure what you mean by linking to https://build.opensuse.org/projects/devel:languages:perl/packages/perl-Perl-Tidy/files/perl-Perl-Tidy.spec?expand=1
That's what cpanspec makes of the version from CPAN. It removes the v from the beginning for rpm.
So: please use the v everywhere and two dots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://metacpan.org/dist/YAML-PP
Tarball name: YAML-PP-v0.39.0.tar.gz
https://metacpan.org/release/TINITA/YAML-PP-v0.39.0/source/META.json#L214
"version" : "v0.39.0",
https://metacpan.org/release/TINITA/YAML-PP-v0.39.0/source/META.yml
version: v0.39.0
https://metacpan.org/release/TINITA/YAML-PP-v0.39.0/source/Changes#L3
v0.39.0 2025-02-10 00:01:45+01:00
https://metacpan.org/dist/YAML-PP/source/lib/YAML/PP.pm#L6
our $VERSION = 'v0.39.0'; # VERSION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and https://blogs.perl.org/users/grinnz/2018/04/a-guide-to-versions-in-perl.html
For this reason it's best to include both a leading "v" and at least two decimal separators for clarity when using tuple versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And linking to https://github.com/search?q=repo%3Amojolicious%2Fmojo%209.40&type=code is irrelevant, because Mojolicious still uses the decimal version format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it says "when using tuple versions" but I wouldn't use tuple versions but decimal version format. Again, I would avoid the ambiguity about 0.35X by using 1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> #74
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it says "when using tuple versions" but I wouldn't use tuple versions but decimal version format. Again, I would avoid the ambiguity about 0.35X by using 1.0.0
1.0.0 is a tupled version. and my suggestion was to use the tupled version format from now on.
|
was replaced by #74 |
No description provided.