Bump github.com/getsentry/sentry-go from 0.36.2 to 0.40.0 #808
Conversation
Bumps [github.com/getsentry/sentry-go](https://github.com/getsentry/sentry-go) from 0.36.2 to 0.40.0. - [Release notes](https://github.com/getsentry/sentry-go/releases) - [Changelog](https://github.com/getsentry/sentry-go/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-go@v0.36.2...v0.40.0) --- updated-dependencies: - dependency-name: github.com/getsentry/sentry-go dependency-version: 0.40.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
|
Beginning January 27, 2026, Dependabot will no longer support the @dependabot merge command. Please use GitHub's native pull request controls instead. Please see the changelog announcement for additional details. |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| require ( | ||
| github.com/coreos/go-systemd/v22 v22.6.0 | ||
| github.com/getsentry/sentry-go v0.36.2 | ||
| github.com/getsentry/sentry-go v0.40.0 |
There was a problem hiding this comment.
Bug: Sentry events are lost on graceful shutdown because sentry.Flush() is not called due to the new async transport in sentry-go v0.40.0.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The shutdownSentry() function in cmd/poseidon/main.go only calls sentry.Flush() when recovering from a panic. With the upgrade to sentry-go v0.40.0 (which includes v0.38.0+ changes), Sentry now uses an async envelope transport and telemetry buffer. This queues events for batch transmission. Consequently, during a normal graceful shutdown, sentry.Flush() is never explicitly called, leading to buffered Sentry events being lost as the application terminates. This results in data loss for any Sentry events captured during normal operation.
💡 Suggested Fix
Modify the shutdownSentry() function or the graceful shutdown path to explicitly call sentry.Flush(logging.GracefulSentryShutdown) during normal application termination, ensuring all buffered Sentry events are sent before exit.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: go.mod#L7
Potential issue: The `shutdownSentry()` function in `cmd/poseidon/main.go` only calls
`sentry.Flush()` when recovering from a panic. With the upgrade to `sentry-go` v0.40.0
(which includes v0.38.0+ changes), Sentry now uses an async envelope transport and
telemetry buffer. This queues events for batch transmission. Consequently, during a
normal graceful shutdown, `sentry.Flush()` is never explicitly called, leading to
buffered Sentry events being lost as the application terminates. This results in data
loss for any Sentry events captured during normal operation.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4158823
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
Bumps github.com/getsentry/sentry-go from 0.36.2 to 0.40.0.
Release notes
Sourced from github.com/getsentry/sentry-go's releases.
... (truncated)
Changelog
Sourced from github.com/getsentry/sentry-go's changelog.
... (truncated)
Commits
f3fc564release: 0.40.09232f5dchore: prepare 0.40.0 (#1150)55ee13efeat: disable Telemetry Buffer (#1149)34261f3Merge branch 'release/0.39.0'a362682release: 0.39.02153b50chore: prepare 0.39.0 (#1144)112f257fix: scheduler should check for ready to flush buffers (#1143)03de096feat: drop rate-limited events (#1138)a2066efMerge branch 'release/0.38.0'eb9fd9frelease: 0.38.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @openhpi-bot.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)