Bump github.com/getsentry/sentry-go from 0.36.2 to 0.39.0 #807
Conversation
Bumps [github.com/getsentry/sentry-go](https://github.com/getsentry/sentry-go) from 0.36.2 to 0.39.0. - [Release notes](https://github.com/getsentry/sentry-go/releases) - [Changelog](https://github.com/getsentry/sentry-go/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-go@v0.36.2...v0.39.0) --- updated-dependencies: - dependency-name: github.com/getsentry/sentry-go dependency-version: 0.39.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
|
Beginning January 27, 2026, Dependabot will no longer support the @dependabot merge command. Please use GitHub's native pull request controls instead. Please see the changelog announcement for additional details. |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| require ( | ||
| github.com/coreos/go-systemd/v22 v22.6.0 | ||
| github.com/getsentry/sentry-go v0.36.2 | ||
| github.com/getsentry/sentry-go v0.39.0 |
There was a problem hiding this comment.
Bug: Sentry events are lost on graceful shutdown because sentry.Flush() is not called for non-panic exits after the SDK upgrade introduced an async buffer.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
Sentry events buffered in memory are lost during normal application shutdown. This occurs because the Sentry SDK upgrade (v0.38.0+) enables an async telemetry buffer by default. The shutdownSentry() function in cmd/poseidon/main.go is designed to only call sentry.Flush() if a panic occurs, which does not happen during a graceful shutdown. Consequently, any events accumulated in the buffer are discarded without being sent to Sentry, leading to a loss of observability data.
💡 Suggested Fix
Add sentry.Flush() to the shutdownSentry() function to ensure buffered events are sent during graceful shutdowns. Alternatively, configure ClientOptions.DisableTelemetryBuffer to true in internal/config/config.go.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: go.mod#L7
Potential issue: Sentry events buffered in memory are lost during normal application
shutdown. This occurs because the Sentry SDK upgrade (v0.38.0+) enables an async
telemetry buffer by default. The `shutdownSentry()` function in `cmd/poseidon/main.go`
is designed to only call `sentry.Flush()` if a panic occurs, which does not happen
during a graceful shutdown. Consequently, any events accumulated in the buffer are
discarded without being sent to Sentry, leading to a loss of observability data.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 3356000
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
|
Superseded by #808. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/getsentry/sentry-go-0.39.0
branch
Bumps github.com/getsentry/sentry-go from 0.36.2 to 0.39.0.
Release notes
Sourced from github.com/getsentry/sentry-go's releases.
... (truncated)
Changelog
Sourced from github.com/getsentry/sentry-go's changelog.
... (truncated)
Commits
a362682release: 0.39.02153b50chore: prepare 0.39.0 (#1144)112f257fix: scheduler should check for ready to flush buffers (#1143)03de096feat: drop rate-limited events (#1138)a2066efMerge branch 'release/0.38.0'eb9fd9frelease: 0.38.02687af7chore: prepare 0.38.0 (#1137)a2df7fafeat: add telemetry scheduler (#1107)99f304eMerge branch 'release/0.37.0'1cd6b6arelease: 0.37.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @openhpi-bot.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)