Skip to content

Conversation

@MPSAJID
Copy link
Contributor

@MPSAJID MPSAJID commented Jan 16, 2026

This PR adds a unit test covering the behavior when OTEL_BLRP_SCHEDULE_DELAY
is set to an invalid value.

Invalid values are logged with a warning and the default schedule delay
(1000ms) is used. The new test documents and locks in this fallback behavior
to reduce the risk of future regressions.

Related to #3806 .

@MPSAJID MPSAJID requested a review from a team as a code owner January 16, 2026 13:30
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 16, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: MPSAJID / name: Sajid Husain Patil (0cabb8e)

@lalitb
Copy link
Member

lalitb commented Jan 16, 2026

LGTM. This covers the non-parseable string case. If the intent is to validate overall robustness of OTEL_BLRP_SCHEDULE_DELAY, it might also be worth adding cases for negative values, zero, overflow, malformed units, or an empty string.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.96%. Comparing base (2868dd1) to head (0cabb8e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3811      +/-   ##
==========================================
+ Coverage   89.94%   89.96%   +0.02%     
==========================================
  Files         225      225              
  Lines        7167     7167              
==========================================
+ Hits         6446     6447       +1     
+ Misses        721      720       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MPSAJID
Copy link
Contributor Author

MPSAJID commented Jan 16, 2026

Thanks for the review!

Agreed ,those are good additional cases to cover. I’ll follow up with a separate PR to extend coverage for other invalid values.

@lalitb lalitb merged commit 7d41406 into open-telemetry:main Jan 16, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants